Recommended import grouping and order?

[mwildehahn]

Is there a recommended import grouping and order for es6 modules?

python has some specifications in PEP as well as some logical extensions: https://code.google.com/p/soc/wiki/PythonStyleGuide#Imports_grouping_and_order

given that es6 imports are reversed, ie instead of:

from <module> import <function> (python)
its
import <function> from <module>

sorting by module isn't as intuitive

[ljharb]

What are the reasons you think ordering matters?

Typically we tend to group external deps first, then relative imports, but beyond that, no particular ordering. If I had to pick, I'd say alphabetical (within "external" and "relative").

[mwildehahn]

its mostly because i write more python than js and am used to alphabetically sorting within groupings (as specified in the google python style guide).

i do think its easier to quickly parse whats being imported/avoid duplicate imports if it has some logical order.

[goatslacker]

We don't have a concrete opinion on ordering. Alpha, external, whatever are all good though.

[benknight]

I agree with @mhahn, perhaps because I've also spent a lot of time writing Python according to PEP8 standards.

Import ordering matters because:

1. Code consistency. Broken windows theory.
2. Easier to to visually scan and see dups.

It's the same argument for any code style guideline, so simply saying it "doesn't matter" isn't really valid. Why does whitespace matter? Why do single versus double quotes matter?

[ljharb]

There's already an eslint rule in our config that prevents dupes, so there's no need for a human to ever worry about that anymore.