v21.1.0 #1790
Closed
v21.1.0 #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaeKimJR
approved these changes
Sep 18, 2019
ljharb
approved these changes
Sep 18, 2019
Contributor
Author
|
hey @noratarano @ljharb , I accidentally ran the major version script, so the tag and package.json says 22.0.0. Should have been minor / 21.1.0. That's my bad. Haven't published to npm yet (permissions issue). Think it's worth trying to fix the commit/tag to a minor version, or are we better off updating the changelog to match the major version bump? Edit: Nora and I decided to clean up the commit/tag to reflect the correct version of 21.1.0. |
caseklim
approved these changes
Sep 18, 2019
Member
|
Yes, cleaning them up is the correct thing to do - only npm publish is irrevocable. |
Contributor
Author
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
21.1.0
DayPicker: week headers: use the passed-in moment object’s instance, to support localy (#1577)@noratarano @caseklim @TaeKimJR can you take a look at this, please?