Change packaging from Stitch to Browserify - #192
Conversation
Conflicts: examples/04_entrypath/Gruntfile.js
|
Can't you use browserify-shim instead of the |
|
@selaux Yes, that's an option that's on my todo list. There are positives and negatives to that approach. On the upside, jquery is also included via browserify. On the downside, using a CDN for jquery requires the use of an additional package (ex. bromote). |
There was a problem hiding this comment.
Perhaps we can simplify some of this by adding in options to the browser field in rendr's package.json
|
Awesome how little modification it requires to simply switch over to Browserify. Still, there's lots of manual specifying where deps are, and which files to bundle, that I would hope to DRY up by rearranging the Rendr source files a bit to better accommodate Browserify, and/or using the 🍻 |
Conflicts: client/router.js examples/00_simple/Gruntfile.js examples/00_simple/package.json examples/01_config/package.json examples/02_middleware/package.json examples/03_sessions/package.json package.json
Remove JSON2 lib from examples
Also modify Rendr to support `require('jquery')`, for better
compatability with Browserify.
|
I've made a bunch of tweaks that get Browserify ready for primetime. Check out the PR to |
Change packaging from Stitch to Browserify
Please note that I have temporarily pointed the package.json values for
rendrandrendr-handlebarsto my updated repos. Obviously, we'll need to change this to new tag numbers once the browserify update is in a tag for each repo.This PR implements browserify for examples 00, 01, 02 and 03. Example 04 has other errors (such as not being updated for the moved app_view file) which need to be corrected before browserify makes sense.
I have also submitted a related RP for
rendr-handlebars.Related RP: rendrjs/rendr-handlebars#8