Internal SwiftUI views should use synthesized memberwise initializer #347

calda · 2025-12-05T18:35:46Z

Summary

This PR updates the redundant memberwise init rule to also apply to structs with private properties. For internal SwiftUI views, prefer defining internal properties rather than private properties so the synthesized memberwise initializer can be used.

Autocorrect is implemented in the new --prefer-synthesized-init-for-internal-structs option added in nicklockwood/SwiftFormat#2291.

/// WRONG
struct PlanetView: View {

  // MARK: Lifecycle

  init(planet: Planet, star: Star) {
    self.planet = planet
    self.star = star
  }

  // MARK: Internal

  var body: some View {
    ...
  }

  // MARK: Private

  private let planet: Planet
  private let star: Star

}

/// RIGHT
struct PlanetView: View {
  let planet: Planet
  let star: Star

  var body: some View {
    ...
  }
}

Reasoning

This reduces boilerplate and makes it easier to add additional properties in the future.

This doesn't apply to SwiftUI dynamic properties, which should always be left private.

…roperties

calda · 2025-12-10T22:47:32Z

README.md


  </details>

- <a id='omit-internal-keyword'></a>(<a href='#omit-internal-keyword'>link</a>) **Omit the `internal` keyword** when defining types, properties, or functions with an internal access control level.


Reorganized the access control rules to all be next to eachother

calda · 2025-12-10T22:47:56Z

README.md

-
-  </details>
-
- <a id='omit-redundant-public'></a>(<a href='#omit-redundant-public'>link</a>) **Avoid using `public` access control in `internal` types.** In this case the `public` modifier is redundant and has no effect.


Merged this rule into the "Access control should be at the strictest level possible" rule -- the wording of that rule already covered this behavior

calda · 2025-12-10T22:48:36Z

README.md

 **[⬆ back to top](#table-of-contents)**

-## Objective-C Interoperability
+## SwiftUI


New top-level SwiftUI section!

calda · 2025-12-10T22:49:29Z

README.md


 **[⬆ back to top](#table-of-contents)**

+## Objective-C Interoperability


Moved this below the "Testing" and "SwiftUI" sections. Realistically we may just want to remove it, but can do that separatety.

I'm glad we moved this further down 👍

bachand

Nice work @calda . LGTM!

bachand · 2025-12-12T18:22:59Z

README.md

 1. [Patterns](#patterns)
 1. [File Organization](#file-organization)
-1. [Objective-C Interoperability](#objective-c-interoperability)
+1. [SwiftUI](#swiftui)


bachand · 2025-12-12T18:26:44Z

README.md

  #### Why?

-  Removing redundant memberwise initializers reduces boilerplate and makes the code more concise. The compiler-synthesized initializers are equivalent to the explicit ones, so there's no functional difference.
+  Removing redundant memberwise initializers reduces boilerplate and makes it easier to add more properties in the future.


bachand · 2025-12-12T18:27:24Z

README.md

  <details>

-  [![SwiftFormat: redundantFileprivate](https://img.shields.io/badge/SwiftFormat-redundantFileprivate-7B0051.svg)](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#redundantFileprivate)
+  [![SwiftFormat: redundantFileprivate](https://img.shields.io/badge/SwiftFormat-redundantFileprivate-7B0051.svg)](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#redundantFileprivate) [![SwiftFormat: redundantPublic](https://img.shields.io/badge/SwiftFormat-redundantPublic-7B0051.svg)](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#redundantPublic)


bachand · 2025-12-12T18:28:17Z

README.md

+  }
+  ```
+
+  However, you can use `internal` access control instead of `private` access control to enable the use of the [compiler-synthesized memberwise initializer](#omit-redundant-memberwise-init).


bachand · 2025-12-12T18:31:35Z

README.md

  }
  ```

+  This doesn't apply to SwiftUI dynamic properties, which should always be left private.


bachand · 2025-12-12T18:32:28Z

README.md


 **[⬆ back to top](#table-of-contents)**

+## Objective-C Interoperability


I'm glad we moved this further down 👍

calda changed the title ~~Update redundant memberwise init rule to apply to structs with private properties~~ Internal SwiftUI views should use synthesized memberwise initializer Dec 8, 2025

calda force-pushed the cal--internal-struct-inits branch 3 times, most recently from 4f3a2d5 to 7935b44 Compare December 10, 2025 22:46

calda added 4 commits December 10, 2025 14:46

Update redundantMemberwiseInit rule to apply to struct with private p…

5a347bf

…roperties

Update example

3d07ed7

Add SwiftUI section

335fdca

Reorganize access control rules

e1779e7

calda force-pushed the cal--internal-struct-inits branch from 7935b44 to e1779e7 Compare December 10, 2025 22:46

calda commented Dec 10, 2025

View reviewed changes

calda enabled auto-merge (squash) December 10, 2025 22:49

calda merged commit 33e066c into master Dec 10, 2025
6 checks passed

calda deleted the cal--internal-struct-inits branch December 10, 2025 22:50

bachand reviewed Dec 12, 2025

View reviewed changes


		</details>

		- <a id='omit-internal-keyword'></a>(<a href='#omit-internal-keyword'>link</a>) Omit the `internal` keyword when defining types, properties, or functions with an internal access control level.


		</details>

		- <a id='omit-redundant-public'></a>(<a href='#omit-redundant-public'>link</a>) Avoid using `public` access control in `internal` types. In this case the `public` modifier is redundant and has no effect.


		[⬆ back to top](#table-of-contents)

		## Objective-C Interoperability

Internal SwiftUI views should use synthesized memberwise initializer #347

Internal SwiftUI views should use synthesized memberwise initializer #347

Uh oh!

Conversation

calda commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Reasoning

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bachand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

calda commented Dec 5, 2025 •

edited

Loading