Skip to content

Conversation

@aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Jan 1, 2026

Summary

Fixes a race condition in the release-drafter workflow where merged PRs sometimes don't appear in the draft release notes when multiple PRs merge in quick succession.

Changes:

  1. Add concurrency group with cancel-in-progress: false to queue (not cancel) overlapping runs
  2. Pin to @v6.0.0 to avoid v6.1.0 bug where the action fails to find existing draft releases and creates duplicates

Note: Uses release-drafter-${{ github.ref }} for the concurrency group since this workflow has both push and pull_request triggers, ensuring PR runs don't block each other while still serializing runs on the same ref.

Review & Testing Checklist for Human

  • Verify release-drafter#1425 is still open before merging
  • After merging, test by merging 2-3 PRs in quick succession and verify all appear in the draft release

Notes

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

Summary by CodeRabbit

  • Chores
    • Improved release workflow stability through configuration enhancements to prevent concurrent release operations and ensure consistent behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

Co-Authored-By: AJ Steers <aj@airbyte.io>
Copilot AI review requested due to automatic review settings January 1, 2026 23:19
@devin-ai-integration
Copy link
Contributor

Original prompt from AJ Steers
Received message in Slack channel #ask-devin-ai:

@Devin - checks to see if any of them need this fix: <https://github.com/airbytehq/airbyte-ops-mcp/pull/183|https://github.com/airbytehq/airbyte-ops-mcp/pull/183>
Thread URL: https://airbytehq-team.slack.com/archives/C08BHPUMEPJ/p1767303466854019

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the ci label Jan 1, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a race condition in the release-drafter workflow that causes merged PRs to be missing from draft release notes when multiple PRs merge simultaneously.

Key Changes:

  • Add concurrency control to serialize workflow runs and prevent race conditions
  • Pin release-drafter action to v6.0.0 to avoid duplicate draft release bug in v6.1.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1767309501-fix-release-drafter-race-condition#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1767309501-fix-release-drafter-race-condition

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@aaronsteers aaronsteers enabled auto-merge (squash) January 1, 2026 23:19
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

A GitHub Actions workflow configuration update that introduces concurrency control to prevent concurrent release-drafter runs and pins the release-drafter action to v6.0.0 from v6 to address a specific bug.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/release_drafter.yml
Added concurrency block with group release-drafter-${{ github.ref }} and cancel-in-progress: false to manage concurrent workflow execution. Pinned release-drafter action from v6 to v6.0.0 with inline comment documenting the version lock rationale.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: fixing a release drafter race condition by adding concurrency controls and pinning the action version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

PyTest Results (Fast)

3 820 tests  +3 398   3 808 ✅ +3 396   6m 34s ⏱️ + 4m 56s
    1 suites ±    0      12 💤 +    3 
    1 files   ±    0       0 ❌  -     1 

Results for commit 9e26c00. ± Comparison against base commit 452acd1.

@aaronsteers aaronsteers merged commit 49ff36e into main Jan 1, 2026
26 checks passed
@aaronsteers aaronsteers deleted the devin/1767309501-fix-release-drafter-race-condition branch January 1, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants