Rss podcast enclosure support#55836
Closed
Dane (dancreee) wants to merge 2 commits intoairbytehq:masterfrom
Closed
Rss podcast enclosure support#55836Dane (dancreee) wants to merge 2 commits intoairbytehq:masterfrom
Dane (dancreee) wants to merge 2 commits intoairbytehq:masterfrom
Conversation
|
Dane (@dancreee) is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Dane (dancreee)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Dane (dancreee)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Dane (dancreee)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
suggested changes
Mar 20, 2025
Contributor
Marcos Marx (marcosmarxm)
left a comment
Marcos Marx (marcosmarxm)
left a comment
There was a problem hiding this comment.
Thanks for the contribution Dane (@dancreee) is it possible to allow maintainers to edit your branch? It is necessary to run tests and update some files.
Some missing:
- Update the connector version in metadata.yaml and docs/connector.md changelog entry
| start_datetime: | ||
| type: MinMaxDatetime | ||
| datetime: "{{ (now_utc() - duration('PT23H')).strftime('%Y-%m-%dT%H:%M:%S%z') }}" | ||
| datetime: "{{ (config['start_date'] if 'start_date' in config else now_utc().strftime('%Y-%m-%dT%H:%M:%S%z')) }}" |
Contributor
There was a problem hiding this comment.
Please return the 23h ago as default not now.
| description: RSS Feed URL | ||
| start_date: | ||
| type: string | ||
| description: "Start date for collecting RSS items in ISO format (e.g., 2020-01-01T00:00:00Z). Items published before this date will be ignored. Defaults to 23 hours ago." |
Contributor
There was a problem hiding this comment.
23 hours ago UTC
| print("---") | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
github-project-automation
bot
moved this from Backlog
to Waiting Contributor
in 🧑🏭 Community Pull Requests
Marcos Marx (marcosmarxm)
moved this from Waiting Contributor
to Inactive
in 🧑🏭 Community Pull Requests
Contributor
|
Close due lack of response. |
github-project-automation
bot
moved this from Inactive
to Done
in 🧑🏭 Community Pull Requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for podcast enclosure URLs in the RSS source connector and implement customizable start date filtering. This enhancement allows the connector to extract media file URLs from podcast RSS feeds and filter entries based on a configurable start date, which is critical for podcast data ingestion use cases.
How
Review guide
airbyte-integrations/connectors/source-rss/source_rss/components.py- Added enclosure URL extraction logic and start date filteringairbyte-integrations/connectors/source-rss/source_rss/manifest.yaml- Added enclosure field to schemaairbyte-integrations/connectors/source-rss/integration_tests/test_podcast_feeds.py- Added tests for podcast feed parsing and start date filteringairbyte-integrations/connectors/source-rss/integration_tests/sample_config.json- Updated sample config to demonstrate start date configurationUser Impact
Users will now be able to:
These enhancements address common requirements for users working with podcast feeds that were previously unsupported.
No negative side effects expected as these are additive changes that don't alter existing functionality.
Can this PR be safely reverted and rolled back?