Skip to content

🐛 VigneshSankar01/BambooHR - connector/fix schema updation for custom reports stream#55885

Closed
Vignesh S (VigneshSankar01) wants to merge 7 commits intoairbytehq:masterfrom
VigneshSankar01:VigneshSankar01/BambooHR-Connector/Fix-Schema-Updation-for-Custom-Reports-Stream
Closed

🐛 VigneshSankar01/BambooHR - connector/fix schema updation for custom reports stream#55885
Vignesh S (VigneshSankar01) wants to merge 7 commits intoairbytehq:masterfrom
VigneshSankar01:VigneshSankar01/BambooHR-Connector/Fix-Schema-Updation-for-Custom-Reports-Stream

Conversation

@VigneshSankar01
Copy link
Contributor

What

  • This fix aims to correct the custom reports stream in airbyte for the bambooHR marketplace connector by updating the schema under that particular stream.

How

Updated the manifest.yaml file: Adjusted the configuration to include all desired fields in the custom_reports_stream. This ensures comprehensive data retrieval from BambooHR.​

Modified the fields parameter: Changed the fields parameter in the request body to reference the configuration value, ensuring that all specified fields are included in the custom report.

Review guide

manifest.yaml: Review the updates made to the custom_reports_stream configuration, ensuring that the fields parameter correctly references the desired fields.)

User Impact

Enhanced Data Retrieval: Users will now receive comprehensive data from BambooHR, as all specified fields are included in the synchronization process.​

Improved Data Integrity: By retrieving all desired columns, data integrity is maintained, facilitating better analysis and reporting.​

No Negative Side Effects: There are no anticipated negative side effects from this update. The changes are designed to enhance the connector's functionality without disrupting existing workflows.

Can this PR be safely reverted and rolled back?

  • YES 💚

@vercel
Copy link

vercel bot commented Mar 20, 2025

Vignesh S (@VigneshSankar01) is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@VigneshSankar01
Copy link
Contributor Author

@VigneshSankar01
Copy link
Contributor Author

relevant issue:
#55890

Copy link
Contributor

@marcosmarxm Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if moving the fields properties will solve the issue Vignesh S (@VigneshSankar01) are you able to run a sync and it's working? Do you mind recording a video of working solution?

@github-project-automation github-project-automation bot moved this from Backlog to Waiting Contributor in 🧑‍🏭 Community Pull Requests Mar 25, 2025
@parthiv11
Copy link
Contributor

Parthiv Makwana (parthiv11) commented Mar 30, 2025

Vignesh S (@VigneshSankar01) i think adding hardcoded fields is not preferred solution as it will make fields name static.

i tried and found that you cane just add {{ config['custom_reports_fields'].split(",") }} as fields value in json body
image

by default only id field is returned, just add fields you sync in custom_reports_fields which will make it dynamic as per usecase

@marcosmarxm
Copy link
Contributor

Closing as the proposal won't solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants