attempt to fix proxy for live tests#55901
Closed
Catherine Noll (clnoll) wants to merge 1 commit intomasterfrom
Closed
attempt to fix proxy for live tests#55901Catherine Noll (clnoll) wants to merge 1 commit intomasterfrom
Catherine Noll (clnoll) wants to merge 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Catherine Noll (clnoll)
requested a review
from Maxime Carbonneau-Leclerc (maxi297)
Contributor
|
Interesting! Let me port this change to my branch and see if it would work |
Contributor
|
It seems like the fix didn’t solve the problem. What I did: This assumes that it will use airbyte-ci-dev from built from the branch. I know this is what happens in CI when the last commit includes a change to the For now, I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?