Skip to content

Conversation

@atritch
Copy link
Contributor

@atritch atritch commented Apr 9, 2025

What

This change introduces the associations stream to the Hubspot connector, enhancing its data integration capabilities. This addition allows users to sync association data, which is crucial for understanding relationships between different Hubspot entities.

How

The code changes involve updating the stream definitions in the Hubspot connector to include the new associations stream. This required modifications to the stream configuration and adjustments to the mock setups in the unit tests to account for the additional stream. The expected stream counts in the tests were updated to reflect this change.

Review guide

  1. source_hubspot/source.py: Check the updated stream definitions and ensure the associations stream is correctly implemented.
  2. unit_tests/test_source.py: Review the changes in the test file to verify that the mock setups and expected counts are updated for the new stream.

User Impact

Users will now have access to the associations stream, allowing them to sync additional data from Hubspot. This enhancement provides a more complete view of their Hubspot data, enabling better insights and decision-making. There are no negative side effects anticipated from this change.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Reverting this PR would remove the associations stream, potentially disrupting users who rely on this new data. It's recommended that any issues be addressed through follow-up patches rather than rolling back the entire change.

@atritch atritch requested a review from a team as a code owner April 9, 2025 17:45
@vercel
Copy link

vercel bot commented Apr 9, 2025

@atritch is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@atritch
Copy link
Contributor Author

atritch commented Apr 9, 2025

I did complete running the unit tests as instructed and found that both before and after we were failing 133 tests.

image

@atritch atritch temporarily deployed to community-ci-auto April 9, 2025 17:54 — with GitHub Actions Inactive
@atritch atritch temporarily deployed to community-ci-auto April 9, 2025 17:56 — with GitHub Actions Inactive
@natikgadzhi
Copy link
Contributor

@brianjlai salvageable?

@brianjlai
Copy link
Contributor

hi @atritch thanks for the contribution!

We're actually in the process of moving Hubspot to our low-code YAML framework. I think the associations stream would be a good candidate to be built in low-code, but we'd like to hold off on introducing the new stream while we are doing the migration. Once we have the streams moved over, we can keep you posted if you want to build associations in low-code.

@atritch
Copy link
Contributor Author

atritch commented Apr 11, 2025

@brianjlai

Thanks for your quick response! Do you have any idea when this might release? I was surprised to see that the bridge table wasn't available in the current integration and think that associations is critical to anyone who wants to do advanced analytics on their hubspot data. (Myself included 😂)

@marcosmarxm
Copy link
Contributor

@atritch sorry to close your contribution as Brian said it won't be possible to accept new Hubspot streams until the connector is moved to low-code. I'll keep you updated when the project is done.

@brianjlai
Copy link
Contributor

@atritch

Do you have any idea when this might release?

Sorry for the delay. We've only just recently begun working on the migration, so hopefully in a couple of weeks. Once we have some of our other CRMSearchStreams migrated, then I think it would be a good time to adapt your contribution. And that way we have some good prior art for the associations stream would be written. Again sorry that we can't accept your contribution at the moment, but hopefully once we get to low-code, the next iteration should be easier.

@kev-datams
Copy link
Contributor

@atritch

Do you have any idea when this might release?

Sorry for the delay. We've only just recently begun working on the migration, so hopefully in a couple of weeks. Once we have some of our other CRMSearchStreams migrated, then I think it would be a good time to adapt your contribution. And that way we have some good prior art for the associations stream would be written. Again sorry that we can't accept your contribution at the moment, but hopefully once we get to low-code, the next iteration should be easier.

Hi @brianjlai , can we now start to implement associations streams as CRMSearchStream has been migrated ? 🙏
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

6 participants