Skip to content

Conversation

@johnwasserman
Copy link
Contributor

What

This PR updates source Airbyte (source-airbyte).

The contributor provided the following description of the change:

removing forward slash

Reviewer checklist

  • Resolve any merge conflicts and validate file diffs (make sure the PR only includes changes intended by the contributor)
  • After reviewing the changes, run the bump-version Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. Add breakingChanges to metadata if necessary.
  • Ensure connector docs are up to date with any changes
  • Run /format-fix to resolve any formatting errors
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

@vercel
Copy link

vercel bot commented Apr 11, 2025

@johnwasserman is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

{{ 'https://' + config['host'] + '/api/public/v1/applications/' if
config['host'] else 'https://api.airbyte.com/v1/applications/'
}}/token
config['host'] else 'https://api.airbyte.com/v1/applications/' }}token
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbgold17 - this is the trailing / that wasn't failing in the builder but was failing check_connection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make sure I understand, this seems like it wasn't actually a trailing slash but rather a double slash?

e.g. https://api.airbyte.com/v1/applications//token

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep exactly

type:
- array
- "null"
items:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnwasserman why is this changing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be new output from the API for connection tags so it wasn't in the previous schema:
Screenshot 2025-04-11 at 2 45 01 PM

@dbgold17
Copy link
Contributor

I don't have permissions to approve this. tagging @bnchrch @natikgadzhi

@johnwasserman johnwasserman enabled auto-merge (squash) April 16, 2025 01:09
@johnwasserman
Copy link
Contributor Author

/bump-version type="minor" changelog="remove formatting error"

@hpereira98
Copy link

Any updates here? We were also trying to use the source-airbyte and it was failing in the connector check/test (we use Airbyte Cloud and required this connector to help us monitor our instance 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants