-
Notifications
You must be signed in to change notification settings - Fork 5k
source-airbyte contribution from johnwasserman #57585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
source-airbyte contribution from johnwasserman #57585
Conversation
|
@johnwasserman is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
| {{ 'https://' + config['host'] + '/api/public/v1/applications/' if | ||
| config['host'] else 'https://api.airbyte.com/v1/applications/' | ||
| }}/token | ||
| config['host'] else 'https://api.airbyte.com/v1/applications/' }}token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbgold17 - this is the trailing / that wasn't failing in the builder but was failing check_connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make sure I understand, this seems like it wasn't actually a trailing slash but rather a double slash?
e.g. https://api.airbyte.com/v1/applications//token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep exactly
| type: | ||
| - array | ||
| - "null" | ||
| items: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnwasserman why is this changing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I don't have permissions to approve this. tagging @bnchrch @natikgadzhi |
|
/bump-version type="minor" changelog="remove formatting error" |
|
Any updates here? We were also trying to use the |

What
This PR updates source Airbyte (source-airbyte).
The contributor provided the following description of the change:
Reviewer checklist
bump-versionAirbyte-CI command locally to update the version of the connector according to the versioning guidelines. AddbreakingChangesto metadata if necessary./format-fixto resolve any formatting errors