bulk load cdk: disable schema change tests for non-retroactive destinations #60896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edgao
merged commit d6e2ba4
into
edgao/direct_load_orchestration
39 of 40 checks passed
edgao
added a commit
that referenced
this pull request
Jun 5, 2025
edgao
added a commit
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like the comment says - if the destination doesn't apply schema changes retroactively, it's probably not doing anything interesting during schema change. So don't even bother running the schema change tests.
(this fixes destination-s3's build, which was failing on the new test, b/c dest-s3 crashes on UnknownType 🤷 )