Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Remove Docker image build from publish operations

Description

This PR modifies the connector publish pipeline to fail hard when a Docker image does not exist, instead of automatically building and pushing the image. The desired behavior is to expect the image is already published and fail if not.

Changes

  • Modified CheckConnectorImageDoesNotExist to return FAILURE status when an image doesn't exist
  • Removed build and push steps from the publish pipeline
  • Updated docstring to reflect the new simplified workflow
  • Maintained handling for pre-releases and already published images

Motivation

This change allows for incremental migration away from using airbyte-ci for publishing. By removing the automatic image building and requiring pre-published images, we create a cleaner separation of concerns between building and publishing operations.

Testing

The changes have been tested by verifying:

  • The pipeline fails when an image doesn't exist
  • The pipeline continues with metadata upload when an image already exists
  • Pre-release handling works correctly

Link to Devin run

https://app.devin.ai/sessions/7267998ffd284b52bfb21918e6694d41

Requested by

Aaron ("AJ") Steers (aj@airbyte.io)

…uilding

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner May 24, 2025 04:41
@devin-ai-integration
Copy link
Contributor Author

Original prompt from Aaron:

Received message in Slack channel #ask-devin-ai:

@Devin - Currently `airbyte-ci` tries to build an image during a publish operation. We'd love to move away from using `airbyte-ci` but we need to do so incrementally. We've found a loophole whereby if we pre-publish the docker image, `airbyte-ci` will notice it already exists and skip publish. However, this is fragile. Can we simply remove the docker image build and publish steps entirely from `airbyte-ci` publish operations? The desired behavior is to expect the image is already published and fail hard if not.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented May 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 6:18am

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…ved build step

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

Closing due to inactivity for more than 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants