Skip to content

fix(source-mssql): classify Azure read-replica error 3947 as transient#78415

Merged
Yarden Carmeli (yardencarmeli) merged 2 commits into
masterfrom
yarden/source-mssql-translate-error-3947
May 26, 2026
Merged

fix(source-mssql): classify Azure read-replica error 3947 as transient#78415
Yarden Carmeli (yardencarmeli) merged 2 commits into
masterfrom
yarden/source-mssql-translate-error-3947

Conversation

@yardencarmeli
Copy link
Copy Markdown
Contributor

@yardencarmeli Yarden Carmeli (yardencarmeli) commented May 25, 2026

What

Fixes 12596

  • Syncs using Azure SQL read replicas intermittently fail with:
    com.microsoft.sqlserver.jdbc.SQLServerException: The service has encountered an error processing your request. Please try again. Error code 3947.
  • The error currently fails the sync when it should retry.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Important

Active progressive rollout warning for source-mssql.

  • (Click to Approve:) Bypass the active progressive rollout warning for source-mssql in the PR comment here.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 📝 AI Documentation:
    • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
    • /ai-create-docs-pr - Creates a documentation PR for connector changes, stacked on the current PR.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

Detected source-mssql Active Rollout: true

Important

Active progressive rollout warning for source-mssql.

To bypass this warning, click on the matching checkbox in the PR description. Look for the checkbox text:

(Click to Approve:) Bypass the active progressive rollout warning for source-mssql in the PR comment

Version on master Branch: 4.4.8

  • RC marker on master branch: false

PR Description Checkbox Status

  • Bypass checkbox checked: true

ℹ️ More Information

Show/hide details...

🤔 What happens if this PR is merged

Checking the checkbox will allow the PR to merge, but it does not necessarily stop the active rollout by itself. The result of the PR merging depends on what connector version is published.

Expected outcomes by type of version number change:

If connector version is not modified in this PR...

No new connector version should be released, and the active rollout should continue unchanged.

If the connector version increments to a higher `-rc` version...

After this PR is merged, the new RC will be published and registered, replacing the active RC marker. When the new RC is registered, the platform cancels any existing non-terminal rollout for this connector without unpinning actors.

After merging, you still need to start the new rollout. During start, pinned actors from the previous rollout can be moved to the new RC.

If the connector version changes from RC to non-RC (GA) version...

You should not merge the PR unless/until the RC has been finalized as canceled. See above Rollout state for detected status.

[!Warning]
This PR should not be merged if the RC rollout is still active. First finalize the active rollout as successful or cancel it in Connector Rollout Manager.

When you finalize an RC rollout as successful, the platform triggers a promotion workflow that strips the -rc suffix, removes stable-version registryOverrides, disables progressive rollout, force-merges that promotion, and unpins actors.

🔁 How to rerun this check

To rerun the check, simply check and uncheck the box, or else modify the PR description and/or title in any way.

Alternatively, you can find the Active Progressive Rollout CI workflow and manually rerun it (although this is generally slower than the above methods).


This comment will be updated as PR and/or rollout status changes.

Workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

source-mssql Connector Test Results

 12 files   12 suites   47s ⏱️
116 tests 116 ✅ 0 💤 0 ❌
226 runs  226 ✅ 0 💤 0 ❌

Results for commit 17649e2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

Project:airbyte-docs
Status: ✅  Deploy successful!
Preview URL:https://airbyte-docs-29clcvzov-airbyte-growth.vercel.app
Latest Commit:17649e2

Deployed with vercel-action

@devin-ai-integration
Copy link
Copy Markdown
Contributor

↪️ Triggering /ai-prove-fix per Hands-Free AI Triage Project triage next step.

Reason: Draft source-mssql fix PR has passing connector tests; only rollout-gate checks are failing due to an active rollout. Prove-fix is still the next validation stage.

https://github.com/airbytehq/oncall/issues/12596

Devin session

@devin-ai-integration
Copy link
Copy Markdown
Contributor

↪️ Intended to trigger /ai-prove-fix per Hands-Free AI Triage Project triage next step, but workflow dispatch is currently failing for AI command workflows.

Reason: Draft source-mssql fix PR has passing connector tests; only rollout-gate checks are failing due to an active rollout. Prove-fix is still the next validation stage.

Operational note: GitHub workflow_dispatch returned HTTP 500/403 with the configured trigger token; repository_dispatch does not start this workflow because the workflow does not subscribe to repository_dispatch. This has been reported as an Ops MCP/workflow blocker.

https://github.com/airbytehq/oncall/issues/12596

Devin session

@yardencarmeli Yarden Carmeli (yardencarmeli) marked this pull request as ready for review May 26, 2026 18:28
@yardencarmeli Yarden Carmeli (yardencarmeli) merged commit 48dc5dd into master May 26, 2026
56 of 58 checks passed
@yardencarmeli Yarden Carmeli (yardencarmeli) deleted the yarden/source-mssql-translate-error-3947 branch May 26, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants