Skip to content

Conversation

@makrsmark
Copy link
Collaborator

I hate the class names. open to suggestions

@makrsmark
Copy link
Collaborator Author

@rpatel3001 - not sure if the positions line up with what acars2pos has

"1L": [compile(dlat + d2("latdeg") + d2("latmin") + d1("latmin10") + dlon + d3("londeg") + d2("lonmin") + d1("lonmin10"))],

I'm guessing i'm missing a type?

Copy link
Contributor

@kevinelliott kevinelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I hear you. I have no better suggestion.

Btw, coords have me thinking that maybe we need to eventually add a raw/formatted value that indicates if a location is current, past, future/planned, etc. Some kind of indication whether or not the value is useful for plotting now or part of a plan/estimate, etc.

Looks good to me.

@makrsmark
Copy link
Collaborator Author

Btw, coords have me thinking that maybe we need to eventually add a raw/formatted value that indicates if a location is current, past, future/planned, etc

So far when raw.position is set, it's a current timestamp. it can be a couple of seconds old, but if i set message_timestamp, that doubles as a 'position valid time'. Otherwise, the message received time (outside of this library) is the best guess

@kevinelliott
Copy link
Contributor

What I mean is the intention of the position. Some positions are stale by hours and may not indicate a "now" position, and some positions/waypoints are in the future for estimates, route planning, or unexpected route updating. Would be good for us to eventually classify these so we know what the intention of the position is.

@rpatel3001
Copy link
Contributor

I have a couple more formats in my logs, plus it looks like a couple extra in the docs, plus more field definitions for the 3 line format.

A selection of the ones in my logs:

the ones acars2pos currently decodes positions from

https://globe.adsbexchange.com/?icao=440081&showTrace=2024-09-22&timestamp=1727025326
000000660N40442W074342,171524 57HOKIR  ,, 35 15-,40517241

https://globe.adsbexchange.com/?icao=440081&showTrace=2024-09-23&timestamp=1727112492
000000660N40388W074116,172811  7RW04R  ,, 62  8-,21317291

https://globe.adsbexchange.com/?icao=440081&showTrace=2024-09-23&timestamp=1727129538
000000660N40562W073507,221217101TEB214 ,,-53 16-,45405401

https://globe.adsbexchange.com/?icao=440020&showTrace=2024-09-24&timestamp=1727216133
000000660N40561W073531,221531101MERIT  ,,-73 13-,45205351

https://globe.adsbexchange.com/?icao=440002&showTrace=2024-09-26&timestamp=1727387839
000000660N40459W074026,215718100MERIT  ,,--- 25-,45405201

https://globe.adsbexchange.com/?icao=4406DE&showTrace=2024-09-27&timestamp=1727458573
000000660N40374W074289,173611 42KILMA  ,,---  8-,39517431

https://globe.adsbexchange.com/?icao=440020&showTrace=2024-09-28&timestamp=1727561574
000000660N40561W073534,221252 95,,---  5-,44705421

F9 variant from docs

https://globe.adsbexchange.com/?icao=A3B05D&showTrace=2024-09-23&timestamp=1727091965
FFT3057,KBOS,1058,    ,NO RAMP CREW IN BOS

https://globe.adsbexchange.com/?icao=A43458&showTrace=2024-09-26&timestamp=1727322909
FFT3423,KLGA,0322,    ,GATE NOT AVAIL UPONARRIVAL

https://globe.adsbexchange.com/?icao=A3ACA6&showTrace=2024-09-28&timestamp=1727547756
FFT3613,KBOS,1745,    ,LATE INBOUND

https://globe.adsbexchange.com/?icao=A44334&showTrace=2024-09-29&timestamp=1727581371
FFT3423,KLGA,0305,    ,LATE INBOUNDFOLLOW UP PROCEDURESLOW TURN

https://globe.adsbexchange.com/?icao=A46345&showTrace=2024-09-29&timestamp=1727634413
FFT1977,KBOS,1745,    ,DLAY DEPLANING PREVIOUSFLT / DLAY BOARDING THISFLT

3 line with no position or wind information

https://globe.adsbexchange.com/?icao=C04463&showTrace=2024-09-26&timestamp=1727358700
00086213200/GS 497000/DEP CYUL/DES MDPC/ETA 1705/GW 700/ALT 37002
CAS/SAT   15.0/FN SWG4426/TFQ 111/DAY 26SEP24/UTC 135139
LON MMMM.MMM/LAT MMMM.MMM/WD ---/WS ---

various miscellaneous messages that look partially encoded or compressed: https://gist.github.com/rpatel3001/fd7ad7a301285f34f4dcb64719f86ff4

@makrsmark
Copy link
Collaborator Author

Thanks @rpatel3001 ! I'll add some specs and the variant you're parsing

@makrsmark
Copy link
Collaborator Author

Going to leave some of the 3-line attributes in "unknown" despite mostly knowing what they are since i don't want to think about it (i know, i know)

@makrsmark makrsmark merged commit d2ae4d2 into airframesio:master Oct 27, 2024
@makrsmark makrsmark deleted the feature/label-1l branch October 27, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants