Fixing Label 44 decoding #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Sorry, this got a little big - I can split out the month and day changes as one PR, and the HHMMSS changes as another, if you want |
* fixing position conversion * adding month
makrsmark
force-pushed
the
bugfix/label-44-positions
branch
from
d12bff7 to
93472d5
Compare
Collaborator
Author
Broken up. this now depends on #190 to pass tests |
Contributor
|
The other two are approved. |
kevinelliott
approved these changes
Nov 12, 2024
Contributor
kevinelliott
left a comment
kevinelliott
left a comment
There was a problem hiding this comment.
LGTM. It was nice to see the extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.