Skip to content

Some position decoding improvement#2

Closed
TLeconte wants to merge 6 commits intoairframesio:masterfrom
TLeconte:TL_POS
Closed

Some position decoding improvement#2
TLeconte wants to merge 6 commits intoairframesio:masterfrom
TLeconte:TL_POS

Conversation

@TLeconte
Copy link
Copy Markdown
Contributor

  • Use decodeStringCoordinates everywhere when possible
  • Use same item format position for all labels
  • Add some position checking
  • Add 3 more position formats
  • Fix some 44 regex

@kevinelliott
Copy link
Copy Markdown
Contributor

@TLeconte Hey Thierry, just seeing that I have overlooked review of this. Thanks for the contribution! Looks like there is some conflicts now (likely due to some new stuff that went in since). Any chance you can update that? I'll review right after.

@kevinelliott
Copy link
Copy Markdown
Contributor

Hey @TLeconte just checking in again.

@kevinelliott
Copy link
Copy Markdown
Contributor

Alright. @johnsom took it on himself to rebase and get this work you did @TLeconte in another PR. Thanks to both of you.

@TLeconte If you see something off or need to make a change, feel free to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants