Skip to content

Merge airr-export into main#15

Merged
schristley merged 4 commits into
mainfrom
airr-export
Nov 11, 2024
Merged

Merge airr-export into main#15
schristley merged 4 commits into
mainfrom
airr-export

Conversation

@bcorrie
Copy link
Copy Markdown
Collaborator

@bcorrie bcorrie commented Nov 9, 2024

No description provided.

Note: needs to be run within the container.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://airr-knowledge.github.io/ak-schema/pr-preview/pr-15/
on branch gh-pages at 2024-11-10 19:49 UTC

@bcorrie
Copy link
Copy Markdown
Collaborator Author

bcorrie commented Nov 9, 2024

Hmm, looks like my previous merge of main -> airr-export got messed up and I accidentally went the wrong way. The merge only created only changes to the akc_convert files, so this should be fine. This merge is now trivial.

@bcorrie bcorrie requested a review from schristley November 10, 2024 19:03
@bcorrie
Copy link
Copy Markdown
Collaborator Author

bcorrie commented Nov 10, 2024

The basics are working for this now... There are a few gaps, as some LifeEvent objects aren't being created correctly, and therefore the links aren't being done correctly, but fundamentally Specimen and Participant and their related LifeEvents are being linked correctly I believe.

I think it would be good to merge this into main (so things don't diverge), and then I will continue on with refinements on this branch.

@schristley schristley merged commit 010b36c into main Nov 11, 2024
@bcorrie bcorrie deleted the airr-export branch November 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants