fix: use absolute paths for bin/ symlinks#21
Merged
Conversation
Symlinks in bin/ were using relative paths: bin/ripgrep -> packages/BurntSushi/ripgrep/.../rg This breaks when calling from different directories. Now using std::fs::canonicalize to resolve absolute paths: bin/ripgrep -> /home/user/.gitclaw/packages/BurntSushi/ripgrep/.../rg Fixes symlink resolution from any working directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Symlinks in bin/ used relative paths:
This breaks when the symlink is called from a different working directory.
Solution
Use
std::fs::canonicalizeto resolve absolute paths before creating symlinks:Testing
Before: Symlink breaks when called from outside ~/.gitclaw
After: Symlink works from any directory