Skip to content

[ACQ-6298] Fix pnpm-workspace.yaml configuration structure#2521

Merged
justinnais merged 1 commit intomasterfrom
ACQ-6298-fix-pnpm-workspace-settings
Feb 12, 2026
Merged

[ACQ-6298] Fix pnpm-workspace.yaml configuration structure#2521
justinnais merged 1 commit intomasterfrom
ACQ-6298-fix-pnpm-workspace-settings

Conversation

@justinnais
Copy link
Copy Markdown
Contributor

@justinnais justinnais commented Feb 12, 2026

Summary

  • Fixed invalid settings: nesting in pnpm-workspace.yaml
  • Removed unnecessary configuration options (autoInstallPeers, strictPeerDependencies)
  • Moved minimumReleaseAge to root level as per pnpm specification
  • Added minimumReleaseAgeExclude for @airtasker/* packages

Related Tickets

  • ACQ-6298

Technical Details

The pnpm-workspace.yaml file had an invalid settings: wrapper that is not supported by pnpm's workspace configuration. Configuration options like minimumReleaseAge should be at the root level of the file, not nested under settings:.

Removed options:

  • autoInstallPeers: true - default behavior, not needed
  • strictPeerDependencies: false - default behavior, not needed

Remove invalid 'settings:' nesting and unnecessary configuration options:
- Remove 'autoInstallPeers: true' (not required for pnpm-workspace.yaml)
- Remove 'strictPeerDependencies: false' (default behavior)
- Move minimumReleaseAge to root level as per pnpm spec
- Add minimumReleaseAgeExclude for @airtasker/* packages

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@justinnais justinnais requested a review from a team as a code owner February 12, 2026 00:17
@justinnais justinnais marked this pull request as draft February 12, 2026 00:30
@justinnais justinnais changed the title Fix pnpm-workspace.yaml configuration structure [ACQ-6298] Fix pnpm-workspace.yaml configuration structure Feb 12, 2026
@justinnais justinnais requested a review from tory24 February 12, 2026 00:35
@justinnais justinnais marked this pull request as ready for review February 12, 2026 00:35
Copy link
Copy Markdown
Contributor

@tory24 tory24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we a

Comment thread pnpm-workspace.yaml
# Security: 7-day delay before using newly published packages (10,080 minutes)
minimumReleaseAge: 10080
minimumReleaseAgeExclude:
- '@airtasker/*'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, i think we need this for the web PR, I think it was an array

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you elaborate here? web is the same no?

Comment thread pnpm-workspace.yaml
minimumReleaseAge: 10080
# Security: 7-day delay before using newly published packages (10,080 minutes)
minimumReleaseAge: 10080
minimumReleaseAgeExclude:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add the description just for inline documentation purposes:

Suggested change
minimumReleaseAgeExclude:
# (Default: undefined) - A list of dependencies that always need to install the newest version immediately
minimumReleaseAgeExclude:

@tory24 tory24 self-requested a review February 12, 2026 01:14
@justinnais justinnais enabled auto-merge (squash) February 12, 2026 01:15
@justinnais justinnais merged commit ea4808a into master Feb 12, 2026
21 checks passed
@justinnais justinnais deleted the ACQ-6298-fix-pnpm-workspace-settings branch February 12, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants