Merged
Conversation
Collaborator
Author
|
@ipmach waiting for review |
ipmach
approved these changes
Feb 11, 2026
Contributor
ipmach
left a comment
There was a problem hiding this comment.
Looks good!, I move the persistency tests to the test_utils folder because the persistency is inside the utils folder.
Contributor
|
@viktorbeck98 if you are ok with my last commit (moving test to the test_utils folder). Feel free to do the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
The module follows a strategy pattern where EventPersistency orchestrates data ingestion and delegates to pluggable EventDataStructure implementations:
New dependencies
polars (used by ChunkedEventDataFrame), pandas (used by EventDataFrame)
Test plan
Solves #15