Skip to content

Added name to update #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Added name to update #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions aixplain/modules/pipeline/asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,11 @@ def __prepare_payload(
dasset = DatasetFactory.get(str(data_asset[node_label]))
asset_payload["dataAsset"]["dataset_id"] = dasset.id

if (
len([dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]])
> 0
):
source_data_list = [
dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]
]

if len(source_data_list) > 0:
data_found = True
else:
for target in dasset.target_data:
Expand Down Expand Up @@ -341,9 +342,11 @@ def run_async(
error = "Validation-related error: Please ensure all required fields are provided and correctly formatted."
else:
status_code = str(r.status_code)
error = f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
error = (
f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
)
response = {"status": "FAILED", "error_message": error}
logging.error(f"Error in request for {name} - {r.status_code}: {error}")
logging.error(f"Error in request for {name} - {r.status_code}: {error}")
except Exception:
response = {"status": "FAILED"}
if resp is not None:
Expand All @@ -355,6 +358,7 @@ def update(
pipeline: Union[Text, Dict],
save_as_asset: bool = False,
api_key: Optional[Text] = None,
name: Optional[Text] = None,
):
"""Update Pipeline

Expand Down Expand Up @@ -382,6 +386,8 @@ def update(
status = "draft"
if save_as_asset is True:
status = "onboarded"
if name:
self.name = name
payload = {
"name": self.name,
"status": status,
Expand Down
3 changes: 2 additions & 1 deletion tests/functional/pipelines/create_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def test_update_pipeline():
pipeline_name = str(uuid4())
pipeline = PipelineFactory.create(name=pipeline_name, pipeline=pipeline_dict)

pipeline.update(pipeline=pipeline_json, save_as_asset=True)
pipeline.update(pipeline=pipeline_json, save_as_asset=True, name="NEW NAME")
assert pipeline.name == "NEW NAME"
assert isinstance(pipeline, Pipeline)
assert pipeline.id != ""
pipeline.delete()
Expand Down