Skip to content

ENG-1102: Default parameter on ModelResponse.get #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ENG-1102: Default parameter on ModelResponse.get #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions aixplain/modules/model/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ def __getitem__(self, key: Text) -> Any:
return self.run_time
raise KeyError(f"Key '{key}' not found in ModelResponse.")

def get(self, key: Text) -> Any:
return self[key]
def get(self, key: Text, default: Optional[Any] = None) -> Any:
try:
return self[key]
except KeyError:
return default

def __repr__(self) -> str:
fields = []
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/model_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_success_poll():
hyp_response = test_model.poll(poll_url=poll_url)
assert isinstance(hyp_response, ModelResponse)
assert hyp_response["completed"] == ref_response["completed"]
assert hyp_response["status"] == ResponseStatus.SUCCESS
assert hyp_response.get("status") == ResponseStatus.SUCCESS


def test_failed_poll():
Expand Down