Fix: update/add missing demo samples#4975
Merged
andrewnester merged 3 commits intoajaxorg:masterfrom Oct 31, 2022
Merged
Conversation
+ Remove nix override thing
Codecov ReportBase: 86.06% // Head: 86.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4975 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 544 544
Lines 41470 41470
Branches 6541 6541
=======================================
Hits 35691 35691
Misses 5779 5779
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Thank you, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This fixes some filename-related issues that would cause 404's to appear in the demo for certain modes, and also backfills some samples for declared modes.
To reproduce one instance of the issue, visit https://ace.c9.io/build/kitchen-sink.html and select "Fortran". The content that is loaded is 404 HTML markup instead of Fortran code.
Summary of changes:
fortran.f90changed tofortran.fso it'd match the 0th file extensionHaxe.hx, Jack.jack, Nix.nixto fix mismatchesThe one straggler that I was unable to identify was the Log (
.log) file type. It doesn't appear to be implemented but it is mentioned in the modelist.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.