Refactor Todo app to simple react code #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change ul to ol for list - change to arrow function - remove generate id form date now because we can use render key with index
ajayns
reviewed
Nov 19, 2018
| ); | ||
| } | ||
|
|
||
| handleChange = e => this.setState({ text: e.target.value }); |
Owner
There was a problem hiding this comment.
If arrow functions are used then the bindings won't be required anymore. This code is trying to illustrate in which case bind should be used for this.
ajayns
reviewed
Nov 19, 2018
| return ( | ||
| <ol> | ||
| {this.props.items.map((item, index) => ( | ||
| <li key={index}>{item.text}</li> |
Owner
There was a problem hiding this comment.
Using index is not recommend as per react docs, rather a unique id of the item is preferred.
Owner
There was a problem hiding this comment.
Here maybe that hasn't been followed in the item.id but the idea is clear, preferably not use any index/iterator values.
Owner
|
Hey, thanks for the PR! I've added some comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
<ul>to<ol>show a list