Clearer error messages when no matches are found #1016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds clearer error messages when no matches are found in a query as per #952.
An error message for the command:
./target/debug/zoxide query foo bar bazWould now read:
zoxide: no match found for 'foo', 'bar', and 'baz'Instead of:
zoxide: no match foundThe intention is to differentiate the error for
zoxide: command not foundand to provide clarity.Warning
This PR adds the method
format_keywordsto theQuerystruct. It is run during every query because of how expected errors are managed with context. It clonesself.keywords; if this is undesirable, it can be refactored.