Fix Sendable conformance warnings #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves Swift 6 Sendable warnings by addressing unnecessary Sendable requirements in the codebase. Changes to Context class: - Wrapped all mutable properties with LockIsolated for thread-safe access - Added LockIsolated utility class using NSRecursiveLock - Context remains Sendable as required by KeywordContext Changes to JSONSchemaBuilder: - Removed unnecessary Sendable conformance from JSONSchemaComponent protocol - Removed @sendable requirement from parse() method - Removed @sendable requirement from JSONSchema transform closure - These components don't cross concurrency boundaries and don't need Sendable The Sendable requirements in JSONSchemaBuilder were defensive/future-proofing but not actually needed - there's no async/await or Task usage in the codebase. Removing them eliminates false-positive warnings about struct initializers not being @sendable (a known Swift limitation). Result: Zero Sendable warnings across the entire codebase.
ecito
force-pushed
the
fix-sendable-conformance
branch
from
3ed2069 to
d973f97
Compare
ajevans99
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves all Swift 6 Sendable conformance warnings in the codebase by removing unnecessary Sendable requirements and properly securing mutable state where needed.
The core insight: The
Sendableconformances inJSONSchemaBuilderwere added defensively but aren't actually needed - there's no async/await or concurrent usage in the codebase. Removing these unnecessary requirements eliminates false-positive warnings about struct initializers not being@Sendable(a known Swift language limitation).Changes to Context class
LockIsolatedfor thread-safe accessLockIsolatedutility class usingNSRecursiveLockContextremainsSendableas it's required byKeywordContext(embedded inSendablekeyword types)Changes to JSONSchemaBuilder protocols
Removed unnecessary
Sendableconformances from:JSONSchemaComponentprotocolJSONPropertyComponentprotocolPropertyCollectionprotocol@Sendableannotations fromparse()methods@SendablefromJSONSchematransform closure@SendablefromAnySchemaComponentvalidate closureType of Change
Additional Notes
Result: Zero Sendable warnings across the entire codebase in Swift 6 language mode.
All existing tests pass (74 tests in core suite). The changes are internal implementation details and don't affect the public API surface.