fix: replace LICENSE files with exact official Apache 2.0 text#356
Merged
ajitpratap0 merged 1 commit intomainfrom Mar 8, 2026
Merged
fix: replace LICENSE files with exact official Apache 2.0 text#356ajitpratap0 merged 1 commit intomainfrom
ajitpratap0 merged 1 commit intomainfrom
Conversation
pkg.go.dev license detection requires an exact match against the official Apache 2.0 template. The previous LICENSE files had minor textual deviations (e.g. 'the Licensor' vs 'Licensor', modified appendix section) that prevented detection. Both root LICENSE and vscode-extension/LICENSE now use the verbatim text from https://www.apache.org/licenses/LICENSE-2.0.txt
|
Claude finished @ajitpratap0's task —— View job PR Review: License Apache 2.0 Fix ✅Todo List:
Review SummaryThis PR successfully addresses the license detection issue by replacing both LICENSE files with the exact official Apache 2.0 text. The changes are correct and appropriate. ✅ Code Quality & Best Practices
✅ Correctness VerificationThe changes correctly address the license detection issues:
✅ Legal & Security Assessment
✅ Performance Considerations
|
ajitpratap0
pushed a commit
that referenced
this pull request
Mar 8, 2026
…ion fix v1.9.2 was cached by the Go module proxy before PR #356 (LICENSE fix) landed, so pkg.go.dev still shows License: UNKNOWN. Bumping to v1.9.3 ensures the proxy fetches a fresh zip with the corrected LICENSE.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pkg.go.dev shows License: UNKNOWN because the LICENSE file had minor deviations from the official Apache 2.0 template text. The license detector does exact matching and couldn't recognize it.
Differences found
the LicensorvsLicensor(2 occurrences)excluding any noticesvsexcluding those noticesFix
Both
LICENSEandvscode-extension/LICENSEreplaced with the verbatim text from https://www.apache.org/licenses/LICENSE-2.0.txtAfter this merges and pkg.go.dev re-indexes, the license should show as Apache-2.0 ✅