fix(tests): update test_update_all for missing identifier URLs#709
Merged
ajslater merged 1 commit intov1.11-performancefrom May 3, 2026
Merged
Conversation
The comicbox alpha bump removed URLs from a couple of metron tag identifiers (genre/012 and story/555). Update the expected fixture values to match: URL field is now None for these identifiers in both AGGREGATED_UPDATE_ALL and QUERIED_UPDATE_ALL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
genre/012and The Beginning'sstory/555. They still carry source/type/key but no longer carry aurl.AGGREGATED_UPDATE_ALLandQUERIED_UPDATE_ALLfixtures intest_update_all.pyso URL isNonefor those two identifiers, restoringtests/importer/test_update_all.py::TestImporterUpdateAll::test_update_all.Test plan
uv run --group test pytest tests/importer/ --no-cov— all 3 importer tests pass.uv run --group lint ruff check tests/importer/test_update_all.pyclean.🤖 Generated with Claude Code