fix codespell config silently skipping all files#753
Merged
Conversation
The `.*` glob in `[tool.codespell].skip` matched every walked path
because `os.walk('.')` prefixes paths with `./`, so codespell scanned
nothing during `make lint` while nvim per-file checks still flagged
typos. Replace `.*` with explicit hidden-dir paths, fix the
`/uv.lock` typo, and add legitimate technical terms (wan, crate, iff,
ser, etc.) to ignore-words-list.
Also wire codespell into the frontend lint script so frontend code
gets spell-checked too, and fix one real typo uncovered (secifies →
specifies in opds/v2/progression.py).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.*glob in[tool.codespell].skipwas matching every walked path (becauseos.walk('.')prefixes paths with./), somake lintwas silently scanning nothing while nvim per-file checks still surfaced real typos..*with explicit hidden-dir paths (./.claude,./.git,./.github,./.venv), switches well-known names (node_modules,bun.lock,package.json,coverage,test-results,uv.lock) to basename patterns so they skip correctly from any working directory, and fixes a/uv.locktypo.frontend/bin/lint.sh(sharing the parent's config via--toml ../pyproject.toml) so frontend code gets spell-checked as part of the frontend lint pass.wan(network),crate(Rust),iff("if and only if" in docstrings),ser/Ser(test fixture abbrev for Series),assertin(assertInunittest method),browseable,doubleclick,re-use,re-using,pre-selected,warmup.secifies→specifiesincodex/views/opds/v2/progression.py.Test plan
bin/lint-python.shexits 0 on develop's contentfrontend/bin/lint.shexits 0codespell .from project root andcodespell --toml ../pyproject.toml .fromfrontend/both find typos when present and pass cleanly otherwise🤖 Generated with Claude Code