Skip to content

audit and fix tool ignore/skip configs#754

Merged
ajslater merged 3 commits into
developfrom
claude/upbeat-mestorf-b0dd09
May 10, 2026
Merged

audit and fix tool ignore/skip configs#754
ajslater merged 3 commits into
developfrom
claude/upbeat-mestorf-b0dd09

Conversation

@ajslater
Copy link
Copy Markdown
Owner

@ajslater ajslater commented May 9, 2026

Summary

Audit pass over the skip/ignore lists across every tool configured in pyproject.toml and cfg/eslint.config.base.js. Fixes a handful of bugs where the patterns weren't doing what they looked like they were doing, drops stale references, removes redundant entries, and normalizes inconsistent path styles across tools.

Bugs fixed

  • ESLint **/*min.css and **/*min.js globs were silently matching files like admin.css (any name ending in the literal substring min.css). Now **/*.min.css / **/*.min.js.
  • [tool.vulture] had test_results/ (underscore) — the real dir is test-results/. Vulture was never actually skipping it.
  • [tool.basedpyright] had a stray top-level builtin = "clear,code,rare" (a misplaced codespell setting) that basedpyright rejected with Config contains unrecognized setting "builtin". Moved into [tool.codespell].
  • [tool.uv.build-backend] source-include: mkdocks.yml typo (real file is mkdocs.yml); .circlci/**, ci/**, top-level strange.jpg referenced non-existent paths.
  • [tool.basedpyright] had "site" listed twice.

Cleanup

  • Removed stale codex/_vendor references from basedpyright, codespell, coverage.run, radon, ruff, ty, vulture, djlint, root eslint.config.js, and .prettierignore.
  • Shrunk [tool.complexipy] exclude to just **/.* and **/__pycache__ since paths = ["codex", "tests"] already gates analysis.
  • Dropped dist from ruff (already in built-in defaults).
  • Dropped djlint entries already covered by use_gitignore = true.
  • Deleted the unused [tool.typos] block (typos is not in any dep group).

Normalization / alignment

  • codespell: removed mixed ./ prefixes; replaced never-matching bare coverage with htmlcov and .coverage*; added *.svg, frontend/src/choices.
  • vulture: changed */.*, */__pycache__*, */node_modules* to **/.*, **/__pycache__, **/node_modules so root-level matches work and patterns line up with the other tools.
  • ty: added config to align with basedpyright's exclude list.
  • ESLint base: added **/coverage/, **/htmlcov/, .eslintcache.
  • radon: added comics/* and vulture_ignorelist.py.

Note: did not change [tool.pytest] to [tool.pytest.ini_options] — pytest 9.0+ uses the bare table.

Test plan

  • python3 -c "import tomllib; tomllib.load(open('pyproject.toml','rb'))" parses cleanly
  • node --check on both ESLint configs
  • make lint — codespell, ruff, ruff format, basedpyright, prettier, eslint, hadolint, actionlint, shellcheck, djlint, mbake all pass
  • CI green
  • Spot-check that codespell still finds typos in normal source paths and skips the new exclusions
  • Spot-check vulture still skips static / node_modules dirs after pattern normalization

(Pre-existing remark . ignored failure in bun run lint is unrelated and reproduces on develop.)

🤖 Generated with Claude Code

ajslater and others added 3 commits May 9, 2026 16:48
- fix eslint **/*min.css and **/*min.js globs that over-matched (e.g. admin.css)
- fix [tool.vulture] test_results/ -> test-results/ typo
- move stray builtin = "clear,code,rare" into [tool.codespell]
- fix uv build-backend source-include typos (mkdocks.yml, .circlci/**) and drop dead entries (ci/**, top-level strange.jpg)
- remove duplicate "site" in [tool.basedpyright] exclude
- drop stale codex/_vendor references from all tool configs
- simplify [tool.complexipy] exclude (paths gating made entries unreachable)
- drop redundant entries from [tool.ruff] (dist already in defaults) and [tool.djlint] (covered by use_gitignore = true)
- normalize codespell skip prefixes; replace bare "coverage" with htmlcov + .coverage*; add *.svg, frontend/src/choices
- add coverage, htmlcov, .eslintcache to ESLint base ignores
- add comics/* and vulture_ignorelist.py to radon exclude
- normalize vulture *​/X* patterns to **/X so root-level matches work; align ty exclude with basedpyright
- delete unused [tool.typos] block

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ajslater ajslater merged commit 57ac98a into develop May 10, 2026
3 checks passed
@ajslater ajslater deleted the claude/upbeat-mestorf-b0dd09 branch May 11, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant