audit and fix tool ignore/skip configs#754
Merged
Merged
Conversation
- fix eslint **/*min.css and **/*min.js globs that over-matched (e.g. admin.css) - fix [tool.vulture] test_results/ -> test-results/ typo - move stray builtin = "clear,code,rare" into [tool.codespell] - fix uv build-backend source-include typos (mkdocks.yml, .circlci/**) and drop dead entries (ci/**, top-level strange.jpg) - remove duplicate "site" in [tool.basedpyright] exclude - drop stale codex/_vendor references from all tool configs - simplify [tool.complexipy] exclude (paths gating made entries unreachable) - drop redundant entries from [tool.ruff] (dist already in defaults) and [tool.djlint] (covered by use_gitignore = true) - normalize codespell skip prefixes; replace bare "coverage" with htmlcov + .coverage*; add *.svg, frontend/src/choices - add coverage, htmlcov, .eslintcache to ESLint base ignores - add comics/* and vulture_ignorelist.py to radon exclude - normalize vulture */X* patterns to **/X so root-level matches work; align ty exclude with basedpyright - delete unused [tool.typos] block Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit pass over the skip/ignore lists across every tool configured in
pyproject.tomlandcfg/eslint.config.base.js. Fixes a handful of bugs where the patterns weren't doing what they looked like they were doing, drops stale references, removes redundant entries, and normalizes inconsistent path styles across tools.Bugs fixed
**/*min.cssand**/*min.jsglobs were silently matching files likeadmin.css(any name ending in the literal substringmin.css). Now**/*.min.css/**/*.min.js.[tool.vulture]hadtest_results/(underscore) — the real dir istest-results/. Vulture was never actually skipping it.[tool.basedpyright]had a stray top-levelbuiltin = "clear,code,rare"(a misplaced codespell setting) that basedpyright rejected withConfig contains unrecognized setting "builtin". Moved into[tool.codespell].[tool.uv.build-backend] source-include:mkdocks.ymltypo (real file ismkdocs.yml);.circlci/**,ci/**, top-levelstrange.jpgreferenced non-existent paths.[tool.basedpyright]had"site"listed twice.Cleanup
codex/_vendorreferences from basedpyright, codespell, coverage.run, radon, ruff, ty, vulture, djlint, rooteslint.config.js, and.prettierignore.[tool.complexipy]exclude to just**/.*and**/__pycache__sincepaths = ["codex", "tests"]already gates analysis.distfrom ruff (already in built-in defaults).use_gitignore = true.[tool.typos]block (typos is not in any dep group).Normalization / alignment
./prefixes; replaced never-matching barecoveragewithhtmlcovand.coverage*; added*.svg,frontend/src/choices.*/.*,*/__pycache__*,*/node_modules*to**/.*,**/__pycache__,**/node_modulesso root-level matches work and patterns line up with the other tools.configto align with basedpyright's exclude list.**/coverage/,**/htmlcov/,.eslintcache.comics/*andvulture_ignorelist.py.Note: did not change
[tool.pytest]to[tool.pytest.ini_options]— pytest 9.0+ uses the bare table.Test plan
python3 -c "import tomllib; tomllib.load(open('pyproject.toml','rb'))"parses cleanlynode --checkon both ESLint configsmake lint— codespell, ruff, ruff format, basedpyright, prettier, eslint, hadolint, actionlint, shellcheck, djlint, mbake all pass(Pre-existing remark
.ignored failure inbun run lintis unrelated and reproduces ondevelop.)🤖 Generated with Claude Code