Matrix URL: pin selected itinerary via /itinerary route (work-2kny)#22
Merged
Conversation
Closes the last remaining item on work-2kny — Matrix per-itinerary URL pinning. Mirrors the Google Flights pin pattern. RE'd from the SPA: clicking a results row navigates to `/itinerary` with a `solution` block carrying three IDs returned by `/v1/search`: - `sessionId` ← response.session - `rh` ← response.solutionSet - `Si` ← solutionList.solutions[i].id `Itinerary.id` is now captured from the API response so the CLI can build the URL. `_emit_urls` upgrades the Matrix line to the pinned form whenever a Matrix-backed result carries all three IDs, falling back to the search URL when missing (e.g. gflight-backend runs, where Matrix session is N/A). Session-scoped: Matrix's IDs expire on the server (~10–30 min observed); stale URLs fail with `Input error for "bookingDetails"`. Docstring spells this out. Same model as Google's session-bound `tfs=` for pinned cards. Includes a byte-exact regression test against a captured SPA URL and a guard test that calendar searches raise TypeError instead of building a nonsense URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/itineraryURL state from a Playwright capture (fill form → click cheapest row → SPA navigates to/itinerary?search=...with asolutionblock)./v1/search:session,solutionSet, and the chosen solution'sid. We capture all three on the existing models, then wire them into_emit_urlsso the Matrix line upgrades from search to pinned whenever the result carries them.Field mapping
solution.<key>sessionIdsessionrhsolutionSetSisolutionList.solutions[i].idWhat's new
links.matrix_itinerary_url(search, *, solution_id, session, solution_set)—SpecificDateSearchonly; raisesTypeErrorfor calendar/followup.models.Itinerary.idfield — explicit capture (the loose base config ignored it before).cli._try_pinned_matrix_url()— mirrors_try_pinned_gflight_url; returns None when any of the three IDs is missing.cli._emit_urls()— uses pinned URL when available; falls back tomatrix_deep_link()otherwise (e.g. gflight-backend runs)./itineraryURL.Session-scoped — known limitation
Matrix's
session/rh/Siare ephemeral (~10–30 min observed). Stale URLs fail withInput error for "bookingDetails" (SolutionSummarizer), "x.solution" is requiredand the SPA shows no booking details. Docstring spells this out. Same model as Google'stfs=pinned cards in that pinning is intended for "share this result I just saw," not long-lived bookmarks.A durable Matrix pin (encoding carriers + flight numbers, like Google's tfs= pinned form) would require either RE'ing Matrix's own "Open in Google Flights" button on the
/itinerarypage or a separate translation step. Out of scope here.Test plan
make check(ruff + ruff format + basedpyright + pytest, 338 passed — 2 new tests)flight search HNL MIA --dep 2026-10-14 --return 2026-10-24 -n 1 --no-pp --backend matrix --matrix-urlemits a pinned/itineraryURL