Revert "feat(auth): passwordless email OTP behind console_auth_redesign"#3185
Conversation
📝 WalkthroughWalkthroughThis PR consolidates the authentication UI by moving all login, signup, and forgot-password flows into a single ChangesAuth Page and Flow Consolidation
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes The consolidation is substantial and cross-cutting: it removes multiple components and API routes, refactors the main auth entry point into a unified implementation, and updates DI wiring. The logic density in the new Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3185 +/- ##
==========================================
- Coverage 63.95% 62.28% -1.67%
==========================================
Files 1098 1009 -89
Lines 26650 24555 -2095
Branches 6454 6037 -417
==========================================
- Hits 17043 15295 -1748
+ Misses 8410 8091 -319
+ Partials 1197 1169 -28
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/deploy-web/src/components/auth/AuthPage/AuthPage.tsx`:
- Around line 97-106: The useCallback for setActiveView closes over
resetMutations but resetMutations is not included in the dependency array,
causing a stale closure; update the dependency array for useCallback to include
resetMutations (i.e., change [searchParams, router] to [searchParams, router,
resetMutations]) so setActiveView always uses the latest resetMutations
implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d8654a61-5f84-4c03-b0d6-ddc67aaa3e47
📒 Files selected for processing (31)
.husky/commit-msgapps/deploy-web/src/components/auth/AuthLayoutV2/AuthLayoutV2.tsxapps/deploy-web/src/components/auth/AuthPage/AuthPage.spec.tsxapps/deploy-web/src/components/auth/AuthPage/AuthPage.tsxapps/deploy-web/src/components/auth/AuthPageLegacy/AuthPageLegacy.spec.tsxapps/deploy-web/src/components/auth/AuthPageLegacy/AuthPageLegacy.tsxapps/deploy-web/src/components/auth/AuthPagePasswordless/AuthPagePasswordless.spec.tsxapps/deploy-web/src/components/auth/AuthPagePasswordless/AuthPagePasswordless.tsxapps/deploy-web/src/components/auth/AuthPagePasswordless/withPersistedPasswordlessFlow.spec.tsxapps/deploy-web/src/components/auth/AuthPagePasswordless/withPersistedPasswordlessFlow.tsxapps/deploy-web/src/components/auth/EmailCodeStart/EmailCodeStart.spec.tsxapps/deploy-web/src/components/auth/EmailCodeStart/EmailCodeStart.tsxapps/deploy-web/src/components/auth/EmailCodeVerify/EmailCodeVerify.spec.tsxapps/deploy-web/src/components/auth/EmailCodeVerify/EmailCodeVerify.tsxapps/deploy-web/src/components/auth/OAuthRow/OAuthRow.spec.tsxapps/deploy-web/src/components/auth/OAuthRow/OAuthRow.tsxapps/deploy-web/src/pages/api/auth/email-code-start.spec.tsapps/deploy-web/src/pages/api/auth/email-code-start.tsapps/deploy-web/src/pages/api/auth/email-code-verify.spec.tsapps/deploy-web/src/pages/api/auth/email-code-verify.tsapps/deploy-web/src/pages/api/auth/password-login.tsapps/deploy-web/src/pages/api/auth/password-signup.tsapps/deploy-web/src/pages/login-v2/index.tsxapps/deploy-web/src/services/app-di-container/server-di-container.service.tsapps/deploy-web/src/services/auth/auth/auth.service.spec.tsapps/deploy-web/src/services/auth/auth/auth.service.tsapps/deploy-web/src/services/session/session.service.spec.tsapps/deploy-web/src/services/session/session.service.tsapps/deploy-web/tests/ui/pages/AuthPagePasswordless.tsapps/deploy-web/tests/ui/passwordless-login.spec.tsapps/deploy-web/tests/ui/services/email-verification/mailsac-code.strategy.ts
💤 Files with no reviewable changes (23)
- apps/deploy-web/src/components/auth/OAuthRow/OAuthRow.spec.tsx
- apps/deploy-web/src/components/auth/AuthPagePasswordless/AuthPagePasswordless.tsx
- apps/deploy-web/src/pages/api/auth/email-code-start.spec.ts
- apps/deploy-web/tests/ui/passwordless-login.spec.ts
- apps/deploy-web/src/components/auth/AuthPagePasswordless/withPersistedPasswordlessFlow.spec.tsx
- apps/deploy-web/tests/ui/pages/AuthPagePasswordless.ts
- apps/deploy-web/src/pages/api/auth/email-code-verify.ts
- apps/deploy-web/src/pages/api/auth/email-code-verify.spec.ts
- apps/deploy-web/src/pages/login-v2/index.tsx
- apps/deploy-web/src/components/auth/OAuthRow/OAuthRow.tsx
- apps/deploy-web/src/components/auth/EmailCodeStart/EmailCodeStart.spec.tsx
- apps/deploy-web/src/pages/api/auth/email-code-start.ts
- apps/deploy-web/src/components/auth/EmailCodeStart/EmailCodeStart.tsx
- apps/deploy-web/src/components/auth/AuthPageLegacy/AuthPageLegacy.spec.tsx
- apps/deploy-web/src/components/auth/AuthPagePasswordless/AuthPagePasswordless.spec.tsx
- apps/deploy-web/src/components/auth/AuthPagePasswordless/withPersistedPasswordlessFlow.tsx
- apps/deploy-web/src/components/auth/EmailCodeVerify/EmailCodeVerify.tsx
- apps/deploy-web/src/components/auth/EmailCodeVerify/EmailCodeVerify.spec.tsx
- apps/deploy-web/src/services/auth/auth/auth.service.ts
- apps/deploy-web/src/components/auth/AuthPageLegacy/AuthPageLegacy.tsx
- apps/deploy-web/src/services/session/session.service.spec.ts
- apps/deploy-web/src/services/auth/auth/auth.service.spec.ts
- apps/deploy-web/src/services/app-di-container/server-di-container.service.ts
Reverts #3178
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes & Improvements
Removals