fix: collect ram requirements from SDL storage#3192
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR refactors memory aggregation in bid screening to account for RAM-class storage volumes as part of effective per-unit memory. The aggregation logic accumulates RAM contributions during storage scanning, and the test suite validates totals partitioning and per-replica memory calculations including the new behavior. ChangesRAM-class storage memory aggregation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
==========================================
- Coverage 63.99% 63.24% -0.76%
==========================================
Files 1098 1057 -41
Lines 26705 25671 -1034
Branches 6481 6313 -168
==========================================
- Hits 17091 16236 -855
+ Misses 8411 8245 -166
+ Partials 1203 1190 -13
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
f2898e0 to
889f2a2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/provider-inventory/src/providers/drizzle.provider.ts`:
- Line 1: Replace the bare DefaultLogger usage with the PostgresLoggerService
wrapper: import DefaultLogger from "drizzle-orm/logger" (instead of
"drizzle-orm"), and instantiate the logger as new DefaultLogger({ writer: new
PostgresLoggerService({ useFormat: config.SQL_LOG_FORMAT === "pretty" }) });
update the provider's logger property to use that wrapped instance (referencing
DefaultLogger and PostgresLoggerService and the config.SQL_LOG_FORMAT flag).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec28f324-dd0f-4148-ad0a-abac4206c4cd
📒 Files selected for processing (4)
apps/provider-inventory/src/providers/drizzle.provider.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.aggregator.spec.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.aggregator.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.repository.integration.ts
889f2a2 to
4eaa65f
Compare
4eaa65f to
9c3f767
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/provider-inventory/src/providers/drizzle.provider.ts`:
- Line 1: Remove the unused DefaultLogger import from the top of
drizzle.provider.ts (it's not passed into the drizzle() call); either delete the
import altogether or, if you intend to enable logging now, replace it by wiring
the existing PostgresLoggerService wrapper used in
apps/api/src/core/providers/postgres.provider.ts into the drizzle() options so a
logger is actually provided to drizzle().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d0de7edd-5e5e-47e6-8cd2-d5ae9c68fb0b
📒 Files selected for processing (4)
apps/provider-inventory/src/providers/drizzle.provider.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.aggregator.spec.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.aggregator.tsapps/provider-inventory/src/repositories/bid-screening/bid-screening.repository.integration.ts
Why
Ref CON-346
What
Summary by CodeRabbit