Skip to content

Conversation

@troian
Copy link
Member

@troian troian commented Oct 29, 2025

fixes tx unjail command
adds validator-set command

@troian troian requested a review from a team as a code owner October 29, 2025 18:52
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Walkthrough

The pull request updates go.mod: bumps pkg.akt.dev/go from v0.1.1 to v0.1.4 and consolidates/introduces a unified replace block redirecting several Cosmos/Akash/Tendermint-related modules to forked or alternate repositories and specific versions.

Changes

Cohort / File(s) Summary
Dependency management
go.mod
Bump pkg.akt.dev/go from v0.1.1v0.1.4; add and consolidate a replace block mapping modules to forks/pinned versions: github.com/99designs/keyringgithub.com/cosmos/keyring v1.2.0, github.com/bytedance/sonicgithub.com/bytedance/sonic v1.14.1, github.com/cometbft/cometbftgithub.com/akash-network/cometbft v0.38.19-akash.1, github.com/cosmos/cosmos-sdkgithub.com/akash-network/cosmos-sdk v0.53.4-akash.7, github.com/cosmos/gogoprotogithub.com/akash-network/gogoproto v1.7.0-akash.2, github.com/gogo/protobufgithub.com/regen-network/protobuf v1.3.3-alpha.regen.1, pin github.com/syndtr/goleveldb to v1.0.1-0.20210819022825-2ae1ddf74ef7, update golang.org/x/exp and pgregory.net/rapid versions; remove duplicate trailing replace block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check correctness of module paths and versions in replace directives.
  • Ensure no leftover duplicate or contradictory replace entries remain.

Possibly related PRs

Poem

🐰 I hopped through go.mod, tidy and keen,
Swapped a few paths and polished the sheen,
Versions aligned, replaces combined,
A little hop forward, dependencies fine! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "chore: bump cli package" directly and accurately describes the primary change visible in the changeset: upgrading pkg.akt.dev/go/cli from v0.1.1 to v0.1.4. The title is concise, clear, and uses appropriate conventional commit formatting with the "chore" prefix. It effectively communicates the main change to reviewers scanning the commit history.
Description Check ✅ Passed The PR description states "fixes tx unjail command" and "adds validator-set command," which relates to the changeset's primary purpose: bumping the pkg.akt.dev/go/cli package from v0.1.1 to v0.1.4. While the description doesn't explicitly detail the go.mod modifications, it describes the functional outcomes that result from the dependency upgrade. The PR title "chore: bump cli package" combined with the description explaining what the bump delivers shows the author has connected the description to the intent of the changeset. The description is not off-topic or completely unrelated to the changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deps

Comment @coderabbitai help to get the list of available commands and usage tips.

fixes tx unjail command

Signed-off-by: Artur Troian <troian@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86191c3 and a10d9e2.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: network-upgrade
  • GitHub Check: lint-shell
  • GitHub Check: sims
  • GitHub Check: build-bins
  • GitHub Check: tests
  • GitHub Check: release-dry-run
  • GitHub Check: lint-go
  • GitHub Check: coverage
  • GitHub Check: build-macos
🔇 Additional comments (2)
go.mod (2)

49-49: Clarify the actual fix — the PR description doesn't match code changes.

The version bump from v0.1.1 to v0.1.4 is confirmed, but the PR title claims "fixes tx unjail command" which isn't evident from these changes. The only unjail reference in the codebase is a flag for exporting jailed validators during state export (util/server/server.go:197), not a tx command. The git diff shows only a version bump and reorganization of the replace block; no implementation of an unjail fix.

Add a CHANGELOG entry documenting what this CLI version bump actually addresses, and update the PR description to accurately reflect the changes. Fill in the issue reference placeholder ("Closes: #XXXX") if applicable.


53-77: Fork maintenance risks confirmed; version conflicts absent.

The review's durability concerns are partially valid:

  • The regen-network/protobuf fork is not actively maintained (latest release Jan 15, 2021) and the Cosmos SDK ecosystem has migrated to cosmos/gogoproto. The replace block comment correctly notes this fork should be "replaced by cosmos/gogoproto in future versions," indicating temporary status.

  • Akash completed a Cosmos SDK v0.53 upgrade in late October 2025 and announced a public evaluation to deprecate or migrate its Cosmos chain, which creates long-term maintenance uncertainty for the akash-network/cosmos-sdk fork.

  • The pinned goleveldb version (v1.0.1-0.20210819022825-2ae1ddf74ef7) is correct and required by Cosmos SDK for v0.53.x compatibility.

  • go mod verify passed with no version conflicts detected.

Action: The go.mod is currently stable, but plan a migration path away from the regen-network/protobuf fork to cosmos/gogoproto per the inline comment, and monitor Akash's chain deprecation evaluation for potential fork sunset timelines.

gotest.tools/v3 v3.5.2
pkg.akt.dev/go v0.1.5
pkg.akt.dev/go/cli v0.1.1
pkg.akt.dev/go/cli v0.1.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Complete the PR checklist before merge.

Per the PR author checklist, the following items are unchecked and should be addressed:

  • ✗ Include the correct type prefix in PR title (currently chore: — verify if this is a breaking change that requires !)
  • ✗ Provide a link to the relevant issue (PR description has placeholder Closes: #XXXX)
  • ✗ Add a changelog entry to CHANGELOG.md
  • ✗ Include necessary unit and integration tests (verify test coverage for the unjail command fix)

Completion of these items is required before this PR can be merged.

🤖 Prompt for AI Agents
In go.mod around line 49, the PR was opened without completing the author
checklist; update the PR title to use the correct type prefix (and add a `!` if
this is a breaking change), replace the placeholder "Closes: #XXXX" in the PR
description with the actual issue link/number, add a clear changelog entry for
the unjail command fix to CHANGELOG.md, and add/adjust unit and integration
tests to cover the unjail command fix (ensure test files are committed and CI
passes) before merging.

@troian troian merged commit 26cf5ae into main Oct 30, 2025
19 checks passed
@troian troian deleted the deps branch October 30, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants