refactor: handle context done as sigint signal

[troian]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

[coderabbitai]

Walkthrough

The changes update the ListenForQuitSignals function signature to accept a context as the first parameter and reorder subsequent parameters for consistency. The function implementation is enhanced to handle context cancellation alongside signal reception using a select statement, with corresponding logging updates. Additionally, the testnet monitor loop's upgrade condition is tightened by increasing the block height threshold from h+1 to h+2.

Changes

Cohort / File(s)	Change Summary
Testnetify Command Updates cmd/akash/cmd/testnetify/testnetify.go, cmd/akash/cmd/testnetify/utils.go	Updated calls to ListenForQuitSignals to match new signature: parameters reordered to (ctx, cancelFn, g, block, logger). Block height upgrade condition in monitor loop tightened from h+1 to h+2.
Server Utility Function Signature util/server/utils.go	Function signature changed to accept context.Context as first parameter and reordered other parameters. Control flow modified to use select statement handling both signal reception and context cancellation. Enhanced logging for both signal and context cancellation paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify all call sites of ListenForQuitSignals have been updated to match the new parameter order (especially important given the reordering)
• Review the select logic in util/server/utils.go to ensure proper context cancellation semantics and signal handling precedence
• Confirm the block height threshold change from h+1 to h+2 aligns with intended behavior and doesn't introduce unintended delays

Poem

🐰 A context flows where signals dance,
Parameters pirouette in new stance,
Select embraces both quit and done,
With blocks that wait—one more to run! 🌟

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	❓ Inconclusive	The description is minimal and uses the default template without substantive details, making it difficult to assess the change's intent.	Provide a meaningful description explaining what problem this refactoring solves and why context cancellation needed to be handled as a signal.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: refactoring the ListenForQuitSignals function to handle context cancellation alongside signal handling.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch handle-signals

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 141d74d and 5233bb9.

📒 Files selected for processing (3)

• cmd/akash/cmd/testnetify/testnetify.go (2 hunks)
• cmd/akash/cmd/testnetify/utils.go (1 hunks)
• util/server/utils.go (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

cmd/akash/cmd/testnetify/testnetify.go (1)

util/server/utils.go (1)

• ListenForQuitSignals (19-42)

cmd/akash/cmd/testnetify/utils.go (1)

util/server/utils.go (1)

• ListenForQuitSignals (19-42)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: network-upgrade
• GitHub Check: release-dry-run
• GitHub Check: sims
• GitHub Check: lint-go
• GitHub Check: tests
• GitHub Check: build-bins
• GitHub Check: coverage
• GitHub Check: build-macos

🔇 Additional comments (4)

util/server/utils.go (1)

19-31: LGTM! Signal handling and context cancellation properly unified.

The refactored implementation correctly handles both signal reception and context cancellation through a select statement, making the function more composable. The logging differentiates between the two paths clearly, and cancelFn() is properly invoked in both cases.

cmd/akash/cmd/testnetify/utils.go (1)

59-59: LGTM! Call site correctly updated.

The call to ListenForQuitSignals properly matches the new signature with the context passed as the first argument and parameters reordered.

cmd/akash/cmd/testnetify/testnetify.go (2)

188-188: LGTM! Call site correctly updated.

The call to ListenForQuitSignals properly matches the new signature with the context and reordered parameters.

---

241-241: Verify the block height threshold increase.

The condition changed from h+1 to h+2, meaning the monitor now waits for 2 additional blocks instead of 1 before exiting. This appears unrelated to the signal handling refactor.

Was this change intentional? If so, please clarify the reasoning—for example, is this needed to ensure testnet stability or handle timing issues introduced by the new signal handling?

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}