-
Notifications
You must be signed in to change notification settings - Fork 258
Fix - warn while creating keys with existing name #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fix #275 |
Fix #275
Signed-off-by: anilCSE <anil@vitwit.com>
gosuri
requested changes
Nov 16, 2019
Member
gosuri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, few changes:
- confirmation should happen in interactive mode only
- it should fail all other modes (shell and json)
Updated key creation to check mode
golangcibot
reviewed
Nov 18, 2019
Fix golang-ci issues
# Conflicts: # cmd/akash/key.go
Resolve conflicts with upstream
golangcibot
reviewed
Nov 18, 2019
Fix golangci issues
Contributor
Author
|
@gosuri resolved the changes requested. |
gosuri
approved these changes
Nov 18, 2019
gosuri
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Submit a pull request
title: 'Fix - warn while creating keys with existing name'
labels: ''
assignees: '@boz @gosuri'
Description
Motivation and Context
design/approvedlabelHow Has This Been Tested?
Types of changes
Checklist:
git commit -s