Skip to content

Conversation

@anilcse
Copy link
Contributor

@anilcse anilcse commented Nov 16, 2019


name: Pull Request
about: Submit a pull request
title: 'Fix - warn while creating keys with existing name'
labels: ''
assignees: '@boz @gosuri'


Description

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@anilcse
Copy link
Contributor Author

anilcse commented Nov 16, 2019

Fix #275

Copy link
Member

@gosuri gosuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, few changes:

  • confirmation should happen in interactive mode only
  • it should fail all other modes (shell and json)

@anilcse anilcse marked this pull request as ready for review November 18, 2019 18:45
@anilcse anilcse requested a review from boz as a code owner November 18, 2019 18:45
@anilcse anilcse requested a review from gosuri November 18, 2019 18:46
@anilcse
Copy link
Contributor Author

anilcse commented Nov 18, 2019

@gosuri resolved the changes requested.

@gosuri gosuri self-requested a review November 19, 2019 01:35
@gosuri gosuri merged commit 57fb473 into akash-network:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants