Rewrite factory evals with meaningful metrics#10
Merged
Merged
Conversation
Replace binary exit-code checks with 6 parsed dimensions: tests (pass/fail ratio), lint (error count), type_check (error count), coverage (actual percentage with 80% threshold), guard_patterns (_glob_match correctness), and config_parser (reparse_config field validation). Closes #5. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
akashgit
added a commit
that referenced
this pull request
Apr 24, 2026
Replace binary exit-code checks with 6 parsed dimensions: tests (pass/fail ratio), lint (error count), type_check (error count), coverage (actual percentage with 80% threshold), guard_patterns (_glob_match correctness), and config_parser (reparse_config field validation). Closes #5. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
akashgit
added a commit
that referenced
this pull request
Apr 25, 2026
Replace binary exit-code checks with 6 parsed dimensions: tests (pass/fail ratio), lint (error count), type_check (error count), coverage (actual percentage with 80% threshold), guard_patterns (_glob_match correctness), and config_parser (reparse_config field validation). Closes #5. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOTALline, fails if < 80%_glob_matchagainst 4 real scope patterns from factory.mdExperimentStore.reparse_config()extracts goal, scope, eval_command, eval_threshold correctlyCoverage now correctly reports 75% and scores 0.75 (previously scored 1.0 with binary check).
Factory experiment #2. Closes #5.
Test plan
uv run python eval/score.pyproduces valid JSON with all 6 dimensions_glob_matchwith real patterns (4/4 pass)reparse_configcorrectness (4/4 fields)🤖 Generated with Claude Code