Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a standard Visual Studio MSI installer for the sortvy application. It configures a deployment project that packages the application for distribution and sets up Windows Explorer context menu integration.
Key Changes:
- Adds Visual Studio installer project with MSI configuration for both Debug and Release builds
- Configures Windows registry entries to add "Open in sortvy" context menu for all file types
- Adds MainForm.resx resource file for the Windows Forms UI
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sortvy/MainForm.resx | Adds standard .NET resource file with XML schema for Windows Forms MainForm component |
| sortvy.sln | Integrates the new installer project into the solution with Debug and Release configurations |
| installer/installer.vdproj | Creates MSI installer project with product metadata, registry settings for context menu integration, and .NET 8.0 runtime requirement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "Name" = "8:.NET Core" | ||
| "Message" = "8:[VSDNETCOREMSG]" | ||
| "AllowLaterVersions" = "11:FALSE" |
There was a problem hiding this comment.
The .NET runtime launch condition has "AllowLaterVersions" set to FALSE. This means users with newer .NET versions installed won't be able to run the installer. Since the project targets .NET 8.0 with SelfContained=false (as seen in sortvy.csproj), users with .NET 8.0 or later should be able to run the application. Consider setting this to TRUE to allow forward compatibility with newer .NET versions.
| "AllowLaterVersions" = "11:FALSE" | |
| "AllowLaterVersions" = "11:TRUE" |
| } | ||
| "Product" | ||
| { | ||
| "Name" = "8:Microsoft Visual Studio" |
There was a problem hiding this comment.
The "Name" field is set to "Microsoft Visual Studio" which appears to be incorrect for this product. This should likely be set to "sortvy" or a similar appropriate product name to match the ProductName field on line 175.
| "Name" = "8:Microsoft Visual Studio" | |
| "Name" = "8:sortvy" |
Standard VS msi style installer