Skip to content

installer#4

Merged
akeda2 merged 4 commits intomasterfrom
msi-installer
Dec 15, 2025
Merged

installer#4
akeda2 merged 4 commits intomasterfrom
msi-installer

Conversation

@akeda2
Copy link
Owner

@akeda2 akeda2 commented Dec 15, 2025

Standard VS msi style installer

@akeda2 akeda2 merged commit ea64382 into master Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a standard Visual Studio MSI installer for the sortvy application. It configures a deployment project that packages the application for distribution and sets up Windows Explorer context menu integration.

Key Changes:

  • Adds Visual Studio installer project with MSI configuration for both Debug and Release builds
  • Configures Windows registry entries to add "Open in sortvy" context menu for all file types
  • Adds MainForm.resx resource file for the Windows Forms UI

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sortvy/MainForm.resx Adds standard .NET resource file with XML schema for Windows Forms MainForm component
sortvy.sln Integrates the new installer project into the solution with Debug and Release configurations
installer/installer.vdproj Creates MSI installer project with product metadata, registry settings for context menu integration, and .NET 8.0 runtime requirement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
"Name" = "8:.NET Core"
"Message" = "8:[VSDNETCOREMSG]"
"AllowLaterVersions" = "11:FALSE"
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .NET runtime launch condition has "AllowLaterVersions" set to FALSE. This means users with newer .NET versions installed won't be able to run the installer. Since the project targets .NET 8.0 with SelfContained=false (as seen in sortvy.csproj), users with .NET 8.0 or later should be able to run the application. Consider setting this to TRUE to allow forward compatibility with newer .NET versions.

Suggested change
"AllowLaterVersions" = "11:FALSE"
"AllowLaterVersions" = "11:TRUE"

Copilot uses AI. Check for mistakes.
}
"Product"
{
"Name" = "8:Microsoft Visual Studio"
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Name" field is set to "Microsoft Visual Studio" which appears to be incorrect for this product. This should likely be set to "sortvy" or a similar appropriate product name to match the ProductName field on line 175.

Suggested change
"Name" = "8:Microsoft Visual Studio"
"Name" = "8:sortvy"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments