Skip to content

Conversation

@Atsushi0904
Copy link
Contributor

確認願います

Signed-off-by: Atsushi0904 <atssp4@gmail.com>
Signed-off-by: Atsushi0904 <atssp4@gmail.com>
@akeyace
Copy link
Owner

akeyace commented Mar 21, 2018

branch 名は lesson/4 だよ!

Signed-off-by: Atsushi0904 <atssp4@gmail.com>
Copy link
Owner

@akeyace akeyace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしたよ

@@ -0,0 +1,6 @@
class Genre:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル名がgenre.py が正解!

self.genre = name

def get(self):
return "ジャンル: " + self.name.get() No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return "ジャンル: " + self.genre が正解!

self.genre = genre

def get(self):
return self.song_name.get(), self.genre.get()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesson_03 の修正が混じってるよ!

def __init__(self, songs):
self.songs = songs

def get(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが正解

   def get(self):
        result = {}
        for i, song in enumerate(self.songs):
            result[i] = song.get()
        sorted(result, key=lambda x: ["ジャンル"])

        return result

@@ -0,0 +1,6 @@
class Songname:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesson_03 の修正が混じってるよ!

@@ -0,0 +1,23 @@
import genre
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesson_03 の修正が混じってるよ!

@@ -0,0 +1,6 @@
class Genre:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesson_03 の修正が混じってるよ!

self.genre = genre

def get(self):
return self.song_name.get(), self.genre.get()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが正解

        return {self.song_name.get(), self.genre.get()}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dictionary 型だよ!

Signed-off-by: Atsushi0904 <atssp4@gmail.com>
Signed-off-by: Atsushi0904 <atssp4@gmail.com>
@Atsushi0904 Atsushi0904 changed the title Lesson4 Lesson/4 Mar 25, 2018
Signed-off-by: Atsushi0904 <atssp4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants