-
Notifications
You must be signed in to change notification settings - Fork 1
Lesson/4 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Lesson/4 #4
Conversation
Signed-off-by: Atsushi0904 <atssp4@gmail.com>
|
branch 名は lesson/4 だよ! |
Signed-off-by: Atsushi0904 <atssp4@gmail.com>
akeyace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューしたよ
| @@ -0,0 +1,6 @@ | |||
| class Genre: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ファイル名がgenre.py が正解!
lesson_04/Atsushi/src/genge.py
Outdated
| self.genre = name | ||
|
|
||
| def get(self): | ||
| return "ジャンル: " + self.name.get() No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return "ジャンル: " + self.genre が正解!
| self.genre = genre | ||
|
|
||
| def get(self): | ||
| return self.song_name.get(), self.genre.get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lesson_03 の修正が混じってるよ!
| def __init__(self, songs): | ||
| self.songs = songs | ||
|
|
||
| def get(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これが正解
def get(self):
result = {}
for i, song in enumerate(self.songs):
result[i] = song.get()
sorted(result, key=lambda x: ["ジャンル"])
return result| @@ -0,0 +1,6 @@ | |||
| class Songname: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lesson_03 の修正が混じってるよ!
| @@ -0,0 +1,23 @@ | |||
| import genre | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lesson_03 の修正が混じってるよ!
| @@ -0,0 +1,6 @@ | |||
| class Genre: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lesson_03 の修正が混じってるよ!
lesson_04/Atsushi/src/song.py
Outdated
| self.genre = genre | ||
|
|
||
| def get(self): | ||
| return self.song_name.get(), self.genre.get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これが正解
return {self.song_name.get(), self.genre.get()}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dictionary 型だよ!
確認願います