PowerShell/Windows support

[GiromettaMarco]

First of all, I would like to thank you for sharing your work.

I'm trying to use the extension on a Windows machine with PowerShell 7 and I've encountered some issues that prevent the extension from working:

Commands (and arguments) are wrapped in double quotes

gutteraid/src/extension.ts

Lines 450 to 452 in e93c8be

	if (process.platform === 'win32') {
	// Escape quotes and backslashes for Windows cmd/PowerShell
	return `"${arg.replace(/"/g, '""').replace(/\\/g, '\\\\')}"`;

This causes commands to be evaluated as strings.

Possible fix:

- 	return `"${arg.replace(/"/g, '""').replace(/\\/g, '\\\\')}"`;
+ 	return `${arg.replace(/"/g, '""').replace(/\\/g, '\\\\')}`;

PowerShell replaced %ERRORLEVEL% with $LASTEXITCODE

gutteraid/src/extension.ts

Lines 465 to 466 in e93c8be

	if (process.platform === 'win32') {
	fullCommand = `${command} && echo %ERRORLEVEL% > "${tempFile}"`;

Possible fix:

see below

AND Operator (&&) skips the rest of the script if the user script fails

In reference to the same line of code as above, the temp file would never be created if the user script fails (for example if the script runs a test and the test fails). && could be replaced with ; (just like in the default script).

Possible fix:

- 	fullCommand = `${command} && echo %ERRORLEVEL% > "${tempFile}"`; 
+ 	fullCommand = `${command}; echo $LASTEXITCODE > "${tempFile}"`;

I can submit a PR if needed.

[akgit18]

Thanks for bringing this to my attention, Marco!

I've split escaping & getting the exit code by detected terminal instead of by platform.

As for wrapping commands in quotes--I plan to continue doing this so that commands that are executable names with spaces work. However, I've now read about the call operator (&) that I should be able to place in front of a powershell command to get it to interpret the next string as a command. Please let me know if this has fixed the issue for you!

[GiromettaMarco]

It works.

Thank you for the good work.