Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b555eaa996
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // The logo filter is resolved against the currently loaded rows only. Do not forward | ||
| // it into Refine's server-side filter state, or older persisted values can blank the list. | ||
| delete forwardedFilters.logo; | ||
| tableProps.onChange(pagination, forwardedFilters, sorter, extra); |
There was a problem hiding this comment.
useTable is configured for server-side pagination, but this handler removes logo before forwarding filters, so the "Has logo/No logo" filter only runs via onFilter on the currently loaded page rows. When vendors span multiple pages, matches on other pages are never requested and pagination totals remain unfiltered, so the new logo filter gives incomplete results; pass the logo filter through to the backend query so it applies to the full dataset.
Useful? React with 👍 / 👎.
akira69
force-pushed
the
review/857-on-860
branch
from
b555eaa to
837aafe
Compare
akira69
force-pushed
the
review/860-on-846
branch
2 times, most recently
from
23efa57 to
6df5e78
Compare
akira69
force-pushed
the
review/857-on-860
branch
from
06c9825 to
d127692
Compare
akira69
force-pushed
the
review/857-on-860
branch
from
fda598b to
741d993
Compare
akira69
force-pushed
the
review/860-on-846
branch
from
6df5e78 to
723bb32
Compare
1 participant
This is a fork-only stacked review PR for upstream Donkie/Spoolman#857.
Use this PR for true stacked review diff only.
Chain:
review/857-on-860Notes:
feat/manufacturer-logo-upstream-splitbranch tree.masterso the upstream PR stays clean.