Closed
Conversation
…plugins Send ActivityPub follow immediately with cron retry
Owner
|
I think all of this is also covered by #574 which takes this further by also migrating subscriptions to ActivityPub plugin followings. |
Author
|
@akirk makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I was seeing where following an account via the friends plugin did not actually follow the account in the activitypub plugin. Resulting in the remote follow request not being sent and ultimately resulting in Activity not landing in the inbox.
🤖 this PR was entirely written by codex
It decided adding a retry method via queuing would be a good idea, I tend to agree, so I left it. If we'd prefer to split that out of this PR, I'm happy to do so.