Don't convert replies to comments without mentions#586
Merged
Conversation
Replies from followed users that don't mention the site owner (e.g., someone continuing their own thread) should not be converted to comments. Gate both the cron scheduling and the actual conversion on the presence of mention-* tags in the friend_tag taxonomy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Test this PR in WordPress PlaygroundYou can test this pull request directly in WordPress Playground: This will install and activate the plugin with the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mention-*tags in thefriend_tagtaxonomyfriends_convert_single_replycron for replies that don't havefriend_mention_tagsskipped_no_mentionreturn inprocess_potential_reply_post()before any remote fetchingThis prevents unwanted comments when followed users continue their own threads (e.g., someone replying to themselves) without mentioning the site owner.
Test plan
friend_post_cachepostsYou can test this on WordPress Playground:
https://playground.wordpress.net/#{%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22git:directory%22,%22url%22:%22https://github.com/akirk/friends%22,%22ref%22:%22no-comments-without-mentions%22,%22refType%22:%22branch%22},%22options%22:{%22activate%22:true}}]}