Fix followers page and add filtering, sorting, and pagination#600
Merged
Conversation
- Fix compatibility with ActivityPub plugin's updated Followers API: use Followers::query() instead of deprecated get_followers_with_count(), convert WP_Post objects to Actors via Remote_Actors::get_actor() before calling to_array() - Replace deprecated count_followers() with Followers::count() - Add filter controls: All, Following, Not Following (replaces ?mutual) - Add sort controls: Newest, Oldest, Name - Add pagination (20 per page) to avoid loading all followers at once - Add loading="lazy" to avatar images - Only classify followers when filter is active (skip on default "All") - Only convert WP_Posts to Actors for the current page (not all followers)
Test this PR in WordPress PlaygroundYou can test this pull request directly in WordPress Playground: This will install and activate the plugin with the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followers::query()returnsWP_Postobjects now, not Actor objects)?mutuallink, with backwards compat)paginate_links()loading="lazy"to avatar imagesTest plan
/friends/followers/— should show 20 followers per page with pagination?filter=not-following&sort=name&fpage=2)?mutualstill works (backwards compat → redirects to Following filter)Test on WordPress Playground:
https://playground.wordpress.net/#{%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22git:directory%22,%22url%22:%22https://github.com/akirk/friends%22,%22ref%22:%22fix/followers-page-improvements%22,%22refType%22:%22branch%22},%22options%22:{%22activate%22:true}}]}