Skip to content

Fix video controls, reaction scroll loss, and PHP warning#604

Merged
akirk merged 1 commit intomainfrom
fix/issue-fixes-for-4.0
Mar 24, 2026
Merged

Fix video controls, reaction scroll loss, and PHP warning#604
akirk merged 1 commit intomainfrom
fix/issue-fixes-for-4.0

Conversation

@akirk
Copy link
Owner

@akirk akirk commented Mar 24, 2026

Summary

I looked at the open issues and found three that are fixable for the 4.0 release:

I also looked at the other open issues — #595 is already fixed, #569 is already fixed in the current code, and the rest (#596, #555, #590, #564, #558, #570) are either user-specific config/cron issues or need deeper architectural work.

Closes #602, closes #588, closes #589, closes #597

Test plan

  • Add an ActivityPub subscription that posts videos — verify video controls are visible
  • Click a reaction emoji on a post — verify the count updates without page reload
  • Pick a new reaction from the emoji picker — verify it appears without page reload
  • Toggle an existing reaction off — verify it disappears without page reload
  • Edit feeds for a subscription with dashboard widgets — verify no PHP warning

WordPress Playground: https://playground.wordpress.net/#{%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22git:directory%22,%22url%22:%22https://github.com/akirk/friends%22,%22ref%22:%22fix/issue-fixes-for-4.0%22,%22refType%22:%22branch%22},%22options%22:{%22activate%22:true}}]}

- Add missing `controls` attribute and `</video>` closing tag for video
  attachments in ActivityPub and Microformats feed parsers (#602, #588)
- Replace window.location.reload() with in-place DOM updates for
  reactions to preserve scroll position (#589)
- Guard against undefined 'friend' array key in dashboard widget
  loop (#597)
@github-actions
Copy link

Test this PR in WordPress Playground

You can test this pull request directly in WordPress Playground:

Launch WordPress Playground

This will install and activate the plugin with the changes from this PR.

@akirk akirk merged commit fb5c4a8 into main Mar 24, 2026
25 checks passed
@akirk akirk deleted the fix/issue-fixes-for-4.0 branch March 24, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant