Fix opening links with target=_blank#85
Merged
akissinger merged 1 commit intoakissinger:masterfrom Nov 14, 2024
Merged
Conversation
A <a href="..." target="_blank"> element can be used by websites to request a link to be opened in a new tab. For some reason, some links in mails seem to have target="_blank" set too. When such a link is clicked, QtWebEngine emits a newWindowRequested signal instead of opening the link directly: https://doc.qt.io/qt-6/qwebenginepage.html#newWindowRequested This commit extracts the link opening code from acceptNavigationRequest to a _handle_link helper method, and also calls that when said signal is emitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<a href="..." target="_blank">element can be used by websites to request a link to be opened in a new tab. For some reason, some links in mails seem to havetarget="_blank"set too.When such a link is clicked, QtWebEngine emits a
newWindowRequestedsignal instead of opening the link directly:https://doc.qt.io/qt-6/qwebenginepage.html#newWindowRequested
This commit extracts the link opening code from
acceptNavigationRequestto a_handle_linkhelper method, and also calls that when said signal is emitted.