logging for auth errors in kafka client binding#1664
Merged
jfallows merged 2 commits intoaklivity:developfrom Mar 27, 2026
Merged
logging for auth errors in kafka client binding#1664jfallows merged 2 commits intoaklivity:developfrom
jfallows merged 2 commits intoaklivity:developfrom
Conversation
jfallows
requested changes
Mar 26, 2026
Comment on lines
+437
to
+438
| int errorCode, | ||
| String topic) |
Contributor
There was a problem hiding this comment.
Instead of adding the extra parameter on the existing method and changing all the call sites to pass null, let's add an override with the same arguments as the original here, and default null for topic, then all the call sites that don't need topic won't need to change to pass null explicitly any more.
| { | ||
| case ERROR_CLUSTER_AUTHORIZATION_FAILED -> event.clusterAuthorizationFailed(traceId, bindingId, apiKey, apiVersion); | ||
| case ERROR_UNSUPPORTED_VERSION -> event.apiVersionRejected(traceId, bindingId, apiKey, apiVersion); | ||
| case ERROR_TOPIC_AUTHORIZATION_FAILED -> event.topicAuthorizationFailed(traceId, bindingId, topic); |
Contributor
There was a problem hiding this comment.
Don't we need apiKey and apiVersion here as well?
I think topic authorization failure can occur on multiple different API calls so we would need to disambiguate, agree?
Comment on lines
+162
to
+167
| public void saslAuthenticationFailed( | ||
| long traceId, | ||
| long bindingId, | ||
| String identity, | ||
| String error) | ||
| { |
Contributor
There was a problem hiding this comment.
If error is not required, then create an overload method same name but without error parameter and call this passing null for error.
jfallows
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1662