Support configuration syntax for metrics with arbitrary attributes#1696
Merged
jfallows merged 11 commits intoaklivity:developfrom Apr 9, 2026
Merged
Support configuration syntax for metrics with arbitrary attributes#1696jfallows merged 11 commits intoaklivity:developfrom
jfallows merged 11 commits intoaklivity:developfrom
Conversation
jfallows
previously approved these changes
Apr 7, 2026
akrambek
changed the title
jfallows
requested changes
Apr 9, 2026
Contributor
jfallows
left a comment
jfallows
left a comment
There was a problem hiding this comment.
Remember to update zilla metrics command too.
| @@ -0,0 +1,39 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
Suggest we simplify this to just http.metrics as the example name
| <properties> | ||
| <jacoco.coverage.ratio>0.74</jacoco.coverage.ratio> | ||
| <jacoco.missed.count>5</jacoco.missed.count> | ||
| <jacoco.missed.count>8</jacoco.missed.count> |
Contributor
There was a problem hiding this comment.
Can we get this back down to 5?
jfallows
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Fixes #1577