feat(binding-mqtt-kafka): deprecate Kafka-group session ownership (#1797)#1802
Merged
Conversation
) Add an optional, currently-unused `store` field to the mqtt-kafka binding options so configurations can prepare for StoreHandler-based session ownership coordination. When `store` is absent, log a one-time deprecation warning per binding instance announcing the upcoming requirement. Existing highlander-group ownership behavior is unchanged. https://claude.ai/code/session_0186rZE8mW1U947XTN4kzZ1x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecation announcement for Kafka consumer-group session ownership in the
mqtt-kafkabinding (Fixes #1797). Schema preparation plus a runtime warning, with no behavior change — the existing highlander-group ownership coordination inMqttKafkaSessionFactoryis untouched.storefield to themqtt-kafkabinding options schema. It is parsed and validated but unused by code in this release.System.out, guarded to worker 0) whenstoreis not configured, announcing thatstorewill be required in an upcoming release.storethroughMqttKafkaOptionsConfig, its builder, and the JSON adapter (read + write).Acceptance criteria
storedeclared onmqtt-kafkaare accepted (parsed and ignored).storeare accepted and log the deprecation warning once per binding instance.MqttKafkaSessionFactorybehavior is unchanged.Notes
System.out.printlnrather than the binding event system, since it is temporary and will be removed whenstore-based ownership lands.CHANGELOG.mdis auto-generated from merged PRs (github-changelog format), so it was not hand-edited — the release notes entry will be generated from this PR.storeschema field is currently a free string and is not yet validated against the top-levelstores:section, matching the "parsed and ignored" scope for this release.Test plan
SchemaTestvalidates a newproxy.store.yamlconfig (10/10 passing).MqttKafkaOptionsConfigAdapterTestcoversstoreread and write (6/6 passing).https://claude.ai/code/session_0186rZE8mW1U947XTN4kzZ1x
Generated by Claude Code