Adjustments for ember-v2 branch#2
Open
mydea wants to merge 11 commits into
Open
Conversation
3 tasks
mydea
commented
May 18, 2026
| }; | ||
| } | ||
|
|
||
| // Manually register instance initializers |
Author
There was a problem hiding this comment.
no idea if there is another way to make this work, couldn't find any docs or examples around this, but this seems to work...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some adjustments to the getsentry#19229 PR branch:
yarn fixat repo root to ensure consistent formattingsetTimeoutapproach in a strict resolver app. This PR changes the behavior to always start the pageload span immediately, even if no router/location is available yet, and simply updates this when it gets the data later. this is more aligned with other SDKs as well and should be safer too, it seems to work in all ember test apps.instrumentEmberAppPerformanceexport as core utility to use